Date: Fri, 25 Jan 2019 14:03:27 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Nikhil Sontakke <nikhils@2ndquadrant.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>,
	Andres Freund <andres@anarazel.de>,
	Robert Haas <robertmhaas@gmail.com>,
	David Steele <david@pgmasters.net>,
	Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
	Simon Riggs <simon@2ndquadrant.com>,
	Craig Ringer <craig@2ndquadrant.com>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	Petr Jelinek <petr.jelinek@2ndquadrant.com>,
	Sokolov Yura <y.sokolov@postgrespro.ru>,
	Stas Kelvich <s.kelvich@postgrespro.ru>,
	Dmitry Dolgov <9erthalion6@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Masahiko Sawada <sawada.mshk@gmail.com>,
	PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] logical decoding of two-phase transactions
Message-ID: <201901251703.r7idekybsep2@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAMGcDxcBmN6jNeQkgWddfhX8HbSjQpW=Uo70iBY3P_EPdp+LTQ@mail.gmail.com>
User-Agent: NeoMutt/20180716-1013-2c1e88
Precedence: bulk

Eyeballing 0001, it has a few problems.

1. It's under-parenthesizing the txn argument of the macros.

2. the "has"/"is" macro definitions don't return booleans -- see
fce4609d5e5b.

3. the remainder of this no longer makes sense:

    /* Do we know this is a subxact?  Xid of top-level txn if so */
-   bool        is_known_as_subxact;
    TransactionId toplevel_xid;

I suggest to fix the comment, and also improve the comment next to the
macro that tests this flag.


(4. the macro names are ugly.)

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services