Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gnjkO-0003eY-Jx for pgsql-hackers@arkaria.postgresql.org; Sun, 27 Jan 2019 12:41:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gnjkN-0006Q0-DV for pgsql-hackers@arkaria.postgresql.org; Sun, 27 Jan 2019 12:41:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gnjkN-0006PX-2E for pgsql-hackers@lists.postgresql.org; Sun, 27 Jan 2019 12:41:11 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gnjkK-0004o4-Vv for pgsql-hackers@lists.postgresql.org; Sun, 27 Jan 2019 12:41:10 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id A58C921908; Sun, 27 Jan 2019 07:41:07 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 27 Jan 2019 07:41:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=W/NlTG/ij0M0C1o3Tf5O3JXxLu5 SJ1mcRUexiTclYE0=; b=ZZrNe+3YwCoxSm7RYvAgFLfzGJbRRB80MP/q+DdhkCv 2rjHTc92ggAYTA9346QPVwLTZsW2MpgkGgSB+Hkv+zQUkBvnCbwP04mu7+FTEXod kuOAFXlO/EVtGgQnXFoR0zRioil3XIwg+GeJz/qTGO/Qyl++JY305fPpQnJ8iPAJ N+pFylNtJ/EiqQJO1rJsPFYGy14seGz0R6cbYexi8E70UhVqPnw8tn8+kdRraWVS jAfpasjte9RW7ifepzudDiiMzHQZHrHa2iOG9og9WnpPlox6izK4Jzk3dTCp0ZST 4ki4bAQApiIUGFH/kAlPNLOlxS2gA9QsQQGXeWqjXyQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=W/NlTG /ij0M0C1o3Tf5O3JXxLu5SJ1mcRUexiTclYE0=; b=PWyBEQ4Wz4m0Kvb5Ve7dQ1 ZQj9t5q4GUy62/pY2CIUtNtV+IpQf6xAC+4MZve7amwb0eLN93KxmZ9rxE8qEKoH B2gxbcPfAx7guyJT0ddAFQxHe9S8ZvC0dOHU/+zFMO4PxGn1H2OhOqyCQf8Bi8wQ nRUibXku4gh138chgttDkASc0CCPVcIf41eHA+7Vt63GpIRXxQnAue+y+uyLMGfG GuAEs+nBu+AZkeFoRUqe9nAJ3acW/OYXz5nRlKAUle1GZeAB5aUfbIAL19RiHp1+ 4EloQZxbLeCAaBUQYN9AlD9TkwyOTf8EEOppkWve/NeZNvNL1mTYqWsje3pdQR6A == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrieekgdegfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdljedtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghh rggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprghquhhivghrrdighiiiqeenuc fkphepiedurddvudehrddufeejrdduiedvnecurfgrrhgrmhepmhgrihhlfhhrohhmpehm ihgthhgrvghlsehprghquhhivghrrdighiiinecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id D9CF410086; Sun, 27 Jan 2019 07:41:03 -0500 (EST) Date: Sun, 27 Jan 2019 21:41:00 +0900 From: Michael Paquier To: Tom Lane Cc: Alvaro Herrera , Peter Eisentraut , "Jamison, Kirk" , "'jesper.pedersen@redhat.com'" , "pgsql-hackers@lists.postgresql.org" , Bruce Momjian Subject: Re: pg_upgrade: Pass -j down to vacuumdb Message-ID: <20190127124100.GA4672@paquier.xyz> References: <201901251708.ha3sgz7dn4rm@alvherre.pgsql> <31929.1548436609@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="T4sUOijqQbZv57TR" Content-Disposition: inline In-Reply-To: <31929.1548436609@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --T4sUOijqQbZv57TR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 25, 2019 at 12:16:49PM -0500, Tom Lane wrote: > Alvaro Herrera writes: >> So let's have it write with a $VACUUMDB_OPTS variable, which is by >> default defined as empty but with a comment suggesting that maybe the >> user wants to add the -j option. This way, if they have to edit it, >> they only have to edit the VACUUMDB_OPTS line instead of each of the two >> vacuumdb lines. >=20 > Even better, allow the script to absorb a value from the environment, > so that it needn't be edited at all. +1. -- Michael --T4sUOijqQbZv57TR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlxNptwACgkQnvQgOdby QH2RARAApzXt+tjNcUi73UWTiDROCtGSyDrlUHjiO5DlzDmDJl/EtQpuDNB0u3vf EiXYElNSwNAHC3mmGDSOJSKQ41X4JN7T17Rpz6TMoImaATgE/p6utIBvzaWAmzG3 k/RmkLA5r+4D6AJjV+n2mqxC5rngr2Ic02Sjthv0YO5CDE880GZjL2rftpB7JSK9 AOEkiNlhJUn8qAxijEqWMzbKkH1pyX8gN4LT0OTX7gHq6KHGvfrMvaX5BstUw0Ks Pe5+L5PVCFdh15i2KuFyOavWfIjF/x3UHgjNWbL6fZUWlxvLVV4LtckpmWT8+UBE voOoNe5oGCrLbzcXugi6uk5INrcMJHLBTmGC8G1S1uV2XdGVuYMB0+y6B1KZIImx cvNxzooYzxt5EokBrTOaOYi+p/6yKa5ItHHLpMBjojbfePWa8tqnrc2PlQ5Pdfbz B+8TZIPEnNNm7L00mOJEtjMqgYAAePkU55ruZ//dUscWO0rEcC5FDxygwqzspgei DfVK6UIrKbYOC2ttSj9uk/tAAQ3J5ieZB3dtzWdk8zg0V7DY7Nj78yMxMCgTonsq iyRz81M/n78pZvKRcOQ3OF4yKA27/A4rIwJMahqmpgaf1VMGSux2hJiV/V6RLfMz 8EChIC8o6uWShrtTv3toFc5+haRlIjxwpBqh5+jneg/Ml2A/LWw= =qc19 -----END PGP SIGNATURE----- --T4sUOijqQbZv57TR--