Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gnkYi-0005kv-F9 for pgsql-hackers@arkaria.postgresql.org; Sun, 27 Jan 2019 13:33:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gnkYh-0006bu-A9 for pgsql-hackers@arkaria.postgresql.org; Sun, 27 Jan 2019 13:33:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gnkYh-0006Ym-0F for pgsql-hackers@lists.postgresql.org; Sun, 27 Jan 2019 13:33:11 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gnkYe-0005u2-Lx for pgsql-hackers@postgresql.org; Sun, 27 Jan 2019 13:33:09 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 862522108A; Sun, 27 Jan 2019 08:33:07 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 27 Jan 2019 08:33:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=qJxzhwnEwpwdIo394Ns1K9QvnXY cJuGuv+phnL7cqu4=; b=BHvMQMW0ge7dHS2vhV9zU3VxZ9q6VrpItC5J7eIdVvY 7q13ntE51VoMbHLAYEoKIDsNV+0HFa91/+DF42Vb1f6JRi18BuBbtrjz14L6+v+6 Cn7DI1EzHR5pffl3nGV17YBKGXFYrRFl61DPOln2ABdV8r0P6i2p+ytQI7vo76bq QrtKsdIGKWemnKT+9jyLx8I4wy1DVshY+Xqgyw2H8RJo8TMWVERZBfVpZO8mk1mV MGQ5J4EdY78QdIUyZwMXIeqqZ8ScwsjAcB5VshkZ0Qt1K8jij4Iku7t0ikgylK+q mq/U+iypyhjPY7IgTBd7FrYevvPCUyiyOtXdN1GR8dQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=qJxzhw nEwpwdIo394Ns1K9QvnXYcJuGuv+phnL7cqu4=; b=m0Sv+NTP+1JUknlFZrIKMk v/zQb0ZsgmE4vbCPD8i0NdmnDoCA18q7H8CQ/0AYORzTEx3o5/qzZIyEWw2zQ8tE zpb3fDNzg4gCyJgENvR1g90RZT2ZRGn2X7Uk6pDKnRvd0sWWlUFZEq8xyaIYgeJ7 9fkho22aB2JXGIhCDqHvlZglAboJ/9a9b6Df02rpBqnwz97PWtdvrZ0HLujhGzx+ gZwVwYWIUpSfmj8MTxeCpiVHJKoymOX2yCN0opARqIVTCPwoQQXmDoBtQ217v7zQ toZR+Nn2jiHodDq8CxtqqhCYbN4Tg/5RWDiWT7AK+qe+dTZ5A9s+zetnCC0cpQ5w == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrieekgdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdljedtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghh rggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprghquhhivghrrdighiiiqeenuc fkphepiedurddvudehrddufeejrdduiedvnecurfgrrhgrmhepmhgrihhlfhhrohhmpehm ihgthhgrvghlsehprghquhhivghrrdighiiinecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id EF124E41F3; Sun, 27 Jan 2019 08:33:04 -0500 (EST) Date: Sun, 27 Jan 2019 22:33:01 +0900 From: Michael Paquier To: "Bossart, Nathan" Cc: Masahiko Sawada , Robert Haas , "pgsql-hackers@postgresql.org" Subject: Re: A few new options for vacuumdb Message-ID: <20190127133301.GA15401@paquier.xyz> References: <20190109010637.GC21835@paquier.xyz> <20190109043316.GH21835@paquier.xyz> <5C971918-E566-41AB-895A-C4793D56B041@amazon.com> <20190122060730.GD8719@paquier.xyz> <20190123034111.GH3873@paquier.xyz> <26A57CB3-2847-495F-93CA-9358959CDAD4@amazon.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ibTvN161/egqYuK8" Content-Disposition: inline In-Reply-To: <26A57CB3-2847-495F-93CA-9358959CDAD4@amazon.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --ibTvN161/egqYuK8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 24, 2019 at 12:49:28AM +0000, Bossart, Nathan wrote: > Oh, wow. Thanks for pointing this out. I should have caught this. > With 0002, we are basically just throwing out the column lists > entirely as we obtain the qualified identifiers from the catalog > query. To fix this, I've added an optional CTE for tracking any > provided column lists. v5-0001 is your test patch for this case, and > v5-0002 splits out the work for split_table_columns_spec(). Committed the test portion for now, still reviewing the rest.. -- Michael --ibTvN161/egqYuK8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIyBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlxNsw0ACgkQnvQgOdby QH2FFQ/44GOpe5zCVb1wt16weBvbUUQsSenmvbyazhFGYftFZORKRJTorqMJdg6U /PXgjNt/VKK8LCWtPVGmeE2AkqTzdMfIbVip6Cv0UjmPNmz4NAhmtWCRbV5yhSnR DsW823ncaQy1aEVyhbSn2VJ0RxOQ8svpWTEl40zUw3rM9f9Ohv0SXSM7QeV4ldnX efF+I6xyOWcZVcZG0n9Hjo/r6dwHVpZks5LesTUpthF7nByJsE8rrfoo2Qw8ZDqI NjvtEntqZg43sFjTvdrLC+9tlCWNSCXqx+5l1CC9Aix3YBRgdph7K7CJqYq54wt9 Dml2QG1sgBRUhsB2zL55Qi4rkh9eb5sxIbpRKnjSk+C9Z26ZJLdK6HcrlemHIOkh eEf94PLrMHU/YfoXQPfOrtrpjNvVA9lBIMP+JwLvAH71/3wbu0nUKbp9kw8lQ0jr rpmyw5bWEYidL4F3yUiaKQppWVfGNqraTSVz7CZ5mNqcU6MztFx2heqJdxXAXk81 dsgfVK8iLiCVW6vGcDiFv9cseEueFoxZKN/0FLS7fcZxn3MLpfUQoSZXOFH0qkiZ stv73E2hTSy9Okz5oBA9mhlpTu4RKVSX+Q1WYyJ+7aGoxfgvFBimn5zaG3SI4/bq 9IGjWmHBr0WTe8niyRIs04jxPPF+wCXQKe7J5BEyhGtJnEtGdQ== =uZCi -----END PGP SIGNATURE----- --ibTvN161/egqYuK8--