Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1goq6j-0001wB-09 for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Jan 2019 13:40:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1goq6h-0000eO-Ku for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Jan 2019 13:40:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1goq6h-0000eC-8f for pgsql-hackers@lists.postgresql.org; Wed, 30 Jan 2019 13:40:47 +0000 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1goq6e-0001Pl-KE for pgsql-hackers@lists.postgresql.org; Wed, 30 Jan 2019 13:40:46 +0000 Received: by mail-ed1-x543.google.com with SMTP id h15so19017939edb.4 for ; Wed, 30 Jan 2019 05:40:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=HfhgRXjo6JZ9gIjWXoz2N91TgV0gph8Zbk+kQ2L0KHo=; b=LRJWarac1vVmMf6c5T10WCgmSDd9IT1NpLcihZQCXgkI3wy3hcTSpDr50NqfZcd5fQ H3EKBDRyqO1Thsx1p9KxEKQMiVSr4GWGtAN/ZWWQwIKd/wbpLcubV+SdK8FZjyvurVvM of+UHG3Mly8EtiMOVlKjSkDbBjPQqLQifjMIoccr1wvJNr7yzJ9f9N6U06ziCcaGkryq p4Mv53wK1PWGbjkKMfaC+66HvFJaJIqQt2Et66F6zB9v7I9O5io0iXCFNl5hJATTldNC 2JQwFZta9+9Va3NwowXtqWuaE//C2ew+CmhsRABvmqVTxsLqh++TLx6YHBdRV6jNHKLn VX2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=HfhgRXjo6JZ9gIjWXoz2N91TgV0gph8Zbk+kQ2L0KHo=; b=awYA899m/Fd6wzHS3Cx/SwbgG6f7wJvzuiA+1zZ3YMD34t5y5cbqZPveHN2H2ovWUU 9FhLAmncC23vq7dhEqxNcdicBuY+bUQwkBu7XlhdRcvJvvcYnTEPXrjTo1lktcAW8t7b oFZ+ujIBKoiUSgFaM1bu9qVj/H4HtosPMiE5ulT3LFOfUp2aIDoWX6A8AJ0ZJBS7a1DT pJJ482PHqz3nTE5C/nMahrePQLRPFpExiD6y8keGPREpEyOABUQF22X42xYZVla+O1UD VRv0TcAgolPhKjOxgvd6o+4fxJA/xOkPGBWiTEwDrsECnxc+UE2UTPY5prLwVdfcVj+V pAmA== X-Gm-Message-State: AJcUukfzmmJTeDQJ8E3VXUIgk6iD1ggTTmPrLFRhjGDS2qVQs8idzvhM vnBfGBr92MKatRWihnrvDJ8hCxgmR+dAf3QK1BV1pp9nlx4zBYaq6Qh8zYVG7eFP9KHSVhHTTLS B52Mhb/EKzfMgYNMUPtopUVWNxk9SOfLBtYyNOKq1x1nQGAVXgr+9EDX5FpAdzTra14pfIZ0J36 jZ6q/xKKwBKWUHLg== X-Google-Smtp-Source: ALg8bN4TapXp5aIQsW+1Q3S3/mlhBycWimE/AkBBtFN2ZhKx51qP8m/n5f4owrrQI6FRYOiJAbUz2w== X-Received: by 2002:a17:906:3397:: with SMTP id v23mr20114100eja.161.1548855643348; Wed, 30 Jan 2019 05:40:43 -0800 (PST) Received: from alvin.alvh.no-ip.org ([212.76.254.98]) by smtp.gmail.com with ESMTPSA id m44sm515121edm.54.2019.01.30.05.40.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Jan 2019 05:40:42 -0800 (PST) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id A9170836; Wed, 30 Jan 2019 08:14:05 -0300 (-03) Date: Wed, 30 Jan 2019 08:14:05 -0300 From: Alvaro Herrera To: Michael Paquier Cc: Postgres hackers Subject: Re: Unused parameters & co in code Message-ID: <201901301114.2vno5l5idtsv@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190130073317.GP3121@paquier.xyz> User-Agent: NeoMutt/20180716-1013-2c1e88 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Jan-30, Michael Paquier wrote: > ReindexPartitionedIndex => parentIdx I'd not change this one, as we will surely want to do something useful eventually. Not that it matters, but it'd be useless churn. > blackholeNoticeProcessor => arg This one's signature is enforced by PQsetNoticeProcessor. > _bt_relbuf => rel (Quite some cleanup here for the btree code) If this is a worthwhile cleanup, let's see a patch. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services