Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gpO8f-0006dg-SF for pgsql-hackers@arkaria.postgresql.org; Fri, 01 Feb 2019 02:01:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gpO8e-0000jA-8i for pgsql-hackers@arkaria.postgresql.org; Fri, 01 Feb 2019 02:01:04 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gpO8d-0000e9-Td for pgsql-hackers@lists.postgresql.org; Fri, 01 Feb 2019 02:01:04 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gpO8a-0007V4-1u for pgsql-hackers@postgresql.org; Fri, 01 Feb 2019 02:01:02 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id A11632E02; Thu, 31 Jan 2019 21:00:58 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 31 Jan 2019 21:00:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=Dcb2kXCVqDGUA/WAxenjg0pM1Gx zOFLe6CzctPrOF4A=; b=wr9U6NvJiOhG/TniJHor6MVqIvSyHQcrSUsgRuVPbiy N4/GTiuRSIgWhF1Ue4E/HeS600FrUYhY+ZJzGl5rZx4/Cy+JF7Lobi1/K+OddYzL vqWAuiOsFzMuN2D5KI4UyNZf4ht9SkVdJIy5usL2o91HHB3Vvur2dkOJ48gNWf60 1BzEEBKblfloazNHhZQJm+G58YuvtSMygPOHdJ4fQDBgw+YFFjbmnlfyqaU/eCki CN2cj7fhMyZvtTo9syvK+GZUREeeBtp2nCSHHhhcNAZ5kneE2826+i2TrkfkyYFC m082MSUG8ZV9BwKRc8rNEiPr5zy9dkJbcwbQ5k+v5BQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Dcb2kX CVqDGUA/WAxenjg0pM1GxzOFLe6CzctPrOF4A=; b=AUCGgUfSUAiPd1RvjuEmlU W2gQ2FZHiG323qACb3wtKOodP/SydKZhZWKl2rcoWxN243iZJs6AwaJg2D50JyZu Ihb92NLXYAwuQ3DQa9QNq021GUXojYHGKpAzYv7bqsxtUlOvgSWGxYBuSRoyn442 zhjlGn0NV/PUpeEhJo7wXBxQsMXeQtJsbXcdf1RywtAzrjvTIul8DN1VDDvWvVWm 2toIkDegLMdNaGlHKTgK4Sv3+kPyEMakeSIX5FkUpCRqV31LIzjDULrRGwQZI11p OSuFEov57eBwy1/6uGVrmNJcrf1lo4Vx8Bj0PM3hLfzsMCpVXw+HdBkYRFrZYzfA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrjeejgdegvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdljedtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghh rggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprghquhhivghrrdighiiiqeenuc fkphepiedurddvudehrddufeejrdduiedvnecurfgrrhgrmhepmhgrihhlfhhrohhmpehm ihgthhgrvghlsehprghquhhivghrrdighiiinecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id E254B10315; Thu, 31 Jan 2019 21:00:54 -0500 (EST) Date: Fri, 1 Feb 2019 11:00:52 +0900 From: Michael Paquier To: Sergei Kornilov Cc: "andres@anarazel.de" , Kyotaro HORIGUCHI , "pgsql-hackers@postgresql.org" Subject: Re: allow online change primary_conninfo Message-ID: <20190201020052.GE2179@paquier.xyz> References: <20181211052249.GB17695@paquier.xyz> <20027911544523224@iva4-f774db2b5297.qloud-c.yandex.net> <9653601544523383@iva8-37fc2ad204cd.qloud-c.yandex.net> <20181213.184233.215171075.horiguchi.kyotaro@lab.ntt.co.jp> <4926831544698308@iva3-294f9af87d55.qloud-c.yandex.net> <20181214075542.GG2921@paquier.xyz> <20190131125837.6gtbdslj5atasuoz@alap3.anarazel.de> <6789441548940402@sas1-fb8a605c4548.qloud-c.yandex.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Lb0e7rgc7IsuDeGj" Content-Disposition: inline In-Reply-To: <6789441548940402@sas1-fb8a605c4548.qloud-c.yandex.net> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --Lb0e7rgc7IsuDeGj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 31, 2019 at 04:13:22PM +0300, Sergei Kornilov wrote: > I my opinion this is not issue, database logs can have sensitive > data. User queries, for example. If we not want expose such info - > it is ok just hide new value from logs with new GUC flag? Or i need > implement masked conninfo for this purpose? You have problems with things in this area for any commands logged and able to show a connection string or a password, which can go down as well to CREATE/ALTER ROLE or FDWs. So for the purpose of what's discussed on this thread it does not sound like a requirement to be able to hide that. Role DDLs can take an already-hashed input to avoid that, still knowing the MD5 hash is sufficient for connection (not for SCRAM!). Now for FDWs.. -- Michael --Lb0e7rgc7IsuDeGj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlxTqFQACgkQnvQgOdby QH2tbw/8Ci38nVpnnsrtbCtbg6xkAYet+SzEHu0PaCW7JcqNVF5N0yT8d2O64nNu kPVvPz2g/VWJddt7rH5vj9pm2dLvcCTxzVj000LhX7iJJp1FIos7P526KWFUxUk6 xreVxHGcgZrte8kAFxwZHn1+Ec/6iQz5bIuXAOPm1fjs/Ss1Y2qga7n4gw9Jn1kb eCuP1RvqTx8GO8M9bNK5U8JH++KAEu2BL0IqbXwqO34OLyfLqXdwTy+Nfqk5ZKZ/ rleahuQDI37XNl7sTSRZC2W2KQZFldH9TO6+oUhlqIgwrhldhj8D7H4JDBu1VRru 9QvgtIgZnK2CDTKQ0EKUqN//qM9ZACyK45ZB6bBBKJ9/f/79+Ye3WFFc6eCEEkYz 4pbAeFYgxO7S9bSLWfNJGCUF3Y20ycRusVkWFzo3EKgaUcVTPV2L+JDFNA7FaW14 bOoNqTUxJYSI/m+mZKSE94W7d2nKua2NhVI1Z+qS/pn1cHZUkBM1YpN1oVPIoYoH PqPoupY6euEnZrdAS23kqJvohOCsitP8zQ/JnRIY1bdmfbcnhylbdlsw6p/jiF6A afC+QHnzh26V5fE4RcYZ3DmKSFUof85STePs4pBMUgJ7W/aczLg3r8IYT+3skEvs /zLzAN7hNJBYK9UDIVtiZpjypoUGNyNhMCp/IRZESO9sSVgiXYA= =ruNY -----END PGP SIGNATURE----- --Lb0e7rgc7IsuDeGj--