Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gpVbH-0007iN-DE for pgsql-hackers@arkaria.postgresql.org; Fri, 01 Feb 2019 09:59:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gpVbF-0003tg-U2 for pgsql-hackers@arkaria.postgresql.org; Fri, 01 Feb 2019 09:59:05 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gpVbF-0003n5-JT for pgsql-hackers@lists.postgresql.org; Fri, 01 Feb 2019 09:59:05 +0000 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gpVbC-0000xg-DF for pgsql-hackers@lists.postgresql.org; Fri, 01 Feb 2019 09:59:04 +0000 Received: by mail-ed1-x543.google.com with SMTP id f9so4910149eds.10 for ; Fri, 01 Feb 2019 01:59:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=ez/8aBiQ3yVxSLppD+unY/IAMYErX0DIcV8HReN9Nas=; b=AYGwDs7J3L/wQGy6KiGwMBJ47Ajy+pY0v+1y39JW7Cqv5HrfxWREJePvuxJF+zQ/Qe y8NlpvFS8UFIHjph9PXpZNbtupCzduDb9RnigSftNEi9YG/Svt5oDaP3rFuNF1zu/6XI 2WiCU+hXfnMEVNe79qO14xBB7XeJDihsbIljtnBFfZxQbOWwwiZXHsUrnkqinWcKPEsk xpWU7XU/CChQmHMqKll7WaIF4GIVL59AeSy8lz7s0ikmWjpp3ANMJNSP20XmTxlYJ7Qm LPRx04UC52gitYfrgruyv1yHPMa/KlaKiQzi8cks5Rz4vRXcu6oET9Lti7MxNzIYlOMZ GfYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=ez/8aBiQ3yVxSLppD+unY/IAMYErX0DIcV8HReN9Nas=; b=Cj9QD3osRuYcxTmttHIpP4+4N8WjktLoa7cNZlCDgYnrhLjCuyaOdx3gjTKAU9ELnR tjUUVIA0r2RAr/vHbo2RrQFGxMAB4cIijxhkeyWYi0zmQtywWOlMi2cFCTPX3zWL8lNf WvUYXDuMeb0DJbfTcekypKWpHafUueq9ceehuOLTz7ly+TWz+ZtbIea2lfluwOOMPhE4 NqVK3h957AmsqU4vHhehNcjqBevSF30Re6DdPBUyfs5hJpb40aNtnRj2fPC4bvDNpRvY kSt5ovQ5UJ2ZYCndcCZk4Sk3ZlwTMkEkvDC/Vb4rWCIUeXiweVI5dGMqgYHDEhxik0y6 tpaw== X-Gm-Message-State: AJcUukcjS2ek58EumkhkkVGA9N3JIXoRjQUfVmwa4flUNudm+i5mmLy9 84czpsEr1A+vry5tttlaLK6dvQ== X-Google-Smtp-Source: ALg8bN7+oYQtV5NREdeGT9uSPwoieRyi4JKTq3iABj8uJYeHqwY8Yf9zk9T0j8htxyv5zzYwr5YJwA== X-Received: by 2002:a17:906:118c:: with SMTP id n12mr29469288eja.228.1549015140236; Fri, 01 Feb 2019 01:59:00 -0800 (PST) Received: from alvin.alvh.no-ip.org (83.224-78-194.adsl-static.isp.belgacom.be. [194.78.224.83]) by smtp.gmail.com with ESMTPSA id g40sm1884204edg.39.2019.02.01.01.58.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Feb 2019 01:58:59 -0800 (PST) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id 6CD509B2; Fri, 1 Feb 2019 06:58:58 -0300 (-03) Date: Fri, 1 Feb 2019 06:58:58 -0300 From: Alvaro Herrera To: "Jamison, Kirk" Cc: "'jesper.pedersen@redhat.com'" , Michael Paquier , Peter Eisentraut , "fabriziomello@gmail.com" , Tom Lane , "pgsql-hackers@lists.postgresql.org" , Bruce Momjian Subject: Re: pg_upgrade: Pass -j down to vacuumdb Message-ID: <201902010958.cf2cbi3d2ule@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716-1013-2c1e88 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Feb-01, Jamison, Kirk wrote: > I'm not sure if misunderstood the purpose of $VACUUMDB_OPTS. I thought what > the other developers suggested is to utilize it so that --jobs for vacuumdb > would be optional and just based from user-specified option $VACUUMDB_OPTS. > By which it would not utilize the amount of jobs used for pg_upgrade. > To address your need of needing a parallel, the script would just then > suggest if the user wants a --jobs option. The if/else for number of jobs is > not needed in that case, maybe only for ifndef WIN32 else case. No Kirk, you got it right -- (some of) those ifdefs are not needed, as adding the --jobs in the command line is not needed. I do think some extra whitespace in the format string is needed. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services