Date: Fri, 1 Feb 2019 08:43:23 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
	Chapman Flack <chap@anastigmatix.net>,
	Amit Khandekar <amitdkhan.pg@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: ArchiveEntry optional arguments refactoring
Message-ID: <201902011143.zzf7gxlxeszc@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <201902011133.t5pccj6jraqe@alvherre.pgsql>
User-Agent: NeoMutt/20180716-1013-2c1e88
Precedence: bulk

On 2019-Feb-01, Alvaro Herrera wrote:

> ... so this code
> 
> 		if (!ropt->noOwner)
> 			sanitized_owner = replace_line_endings(te->owner);
> 		else
> 			sanitized_owner = pg_strdup("-");
> 
> can become
> 		sanitized_owner = replace_line_endings(te->owner, true);

Sorry, there's a silly bug here because I picked the wrong example to
hand-type.  The proposed pattern works fine for the schema cases, not
for this owner case.  The owner case is correctly handled (AFAICT) in
the patch I posted.  (Also for some reason I decided to go with "hyphen"
instead of "dash" in the argument name.  Not sure if anybody cares
strongly about using the right terminology there (I don't know which it
is).

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services