Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1grXXU-0004Mp-4p
	for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Feb 2019 00:27:36 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1grXXS-0001Mr-Qd
	for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Feb 2019 00:27:34 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1grXWu-0002x6-2K
	for pgsql-hackers@lists.postgresql.org; Thu, 07 Feb 2019 00:27:00 +0000
Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1grXWq-0006am-7V
	for pgsql-hackers@postgresql.org; Thu, 07 Feb 2019 00:26:59 +0000
Received: by mail-qt1-x843.google.com with SMTP id l11so10185984qtp.0
        for <pgsql-hackers@postgresql.org>;
 Wed, 06 Feb 2019 16:26:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition
         :content-transfer-encoding:in-reply-to:user-agent;
        bh=c+QaokN/ZLYi0NN/b9VEvM3GqvuJrW0Vsl6+Tluzjvk=;
        b=HWK7rFWWpboGUoT3M4kvimOPI50D3wSE6YTZM4dYmchSG4wmj4whfsetSJrNg3+U1T
         bjhN0Y5Vm3e37TZU6ARnSJg1wysSkWlGtEG2GWJuc6vy33BcCmIaub18N+YU6GK955eD
         BC0i4fMLbpm+lL6AHet7Cqkz22TeShxKQAEltwwY8Sfq3hct80GaiCuoe1YVChYAwKHj
         lV/BbdyXR+jXE/mY08V+HKb1fQPp9L5Eeel70HP+82LeLcUDAOSGjIDlI7w++l4x1J1T
         g8EAcX+RZrLmHzqV68d3lsg/TrCehjyNL03bIfFHD7sDk95wOw4JlZHxsvzd3z6Y0wl8
         c+aA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition:content-transfer-encoding:in-reply-to
         :user-agent;
        bh=c+QaokN/ZLYi0NN/b9VEvM3GqvuJrW0Vsl6+Tluzjvk=;
        b=IUcwBiIosJNW7fbu5ykqkx6as6XgsFJP5NmlEGDSZR1kWqCvaUU4YudXjA8BFBzS30
         cQRhUmxnpB60oHIgr4/Frl71gVlFTrsNsjHtkrbQRJilC7pJTy8avJyMKA20SKzjza9P
         D08O7G16z9vUKIPjWoaG7iZwoGJfSf6eTjgtpMxphppP1PP1lYtjMnCZQYmWbS0MUrWr
         8bsIbPbPH52arvvuu1/I2TenusJKc+S5fRIVF1AQ8Rb/iGSiCd+cxmHN3Kce8GmE1AgN
         0iihir5z7YVQ65BgBTf6gCKXdvPW3Dy7moOJbLvHHA/eDiSr1+LtWS/NsOK00DCAqS/a
         oUFw==
X-Gm-Message-State: AHQUAuYAFaz6uGJzbA58AqUvOXXcXDSikfo18bMD2k2kRTcHQH/KKaVu
	mRDNEXQjAoaA+FXVhKdpWwhDaWcpJfU=
X-Google-Smtp-Source: 
 AHgI3IaBwziiZ/azEY61jG5crOlwzCJnWI/dLUke4Ok0zUmJk6g2IxMlbh7mixH4mzrTkaGFG64Ggw==
X-Received: by 2002:a0c:f584:: with SMTP id k4mr9890120qvm.22.1549499214831;
        Wed, 06 Feb 2019 16:26:54 -0800 (PST)
Received: from nimloth.alvh.no-ip.org ([201.186.80.67])
        by smtp.gmail.com with ESMTPSA id
 c205sm17332703qkg.15.2019.02.06.16.26.52
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Wed, 06 Feb 2019 16:26:52 -0800 (PST)
Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000)
	id 2EA4F12424B; Wed,  6 Feb 2019 13:30:50 -0300 (-03)
Date: Wed, 6 Feb 2019 13:30:50 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Arseny Sher <a.sher@postgrespro.ru>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>,
	Alexander Lakhin <a.lakhin@postgrespro.ru>
Subject: Re: Too rigorous assert in reorderbuffer.c
Message-ID: <20190206163050.GA22952@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8736p18e7c.fsf@ars-thinkpad>
User-Agent: Mutt/1.9.4 (2018-02-28)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

On 2019-Feb-06, Arseny Sher wrote:

> 
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> 
> > note the additional pg_temp_XYZ row in the middle.  This is caused by
> > the rewrite in ALTER TABLE.  Peter E fixed that in Pg11 in commit
> > 325f2ec55; I don't think there's much to do in the backbranches other
> > than hide the pesky record to avoid it breaking the test.
> 
> Oh, I see. Let's just remove the first insertion then, as in attached.
> I've tested it on master and on 9.4.

Ah, okay.  Does the test still fail when run without the code fix?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services