Date: Thu, 7 Feb 2019 10:31:35 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andreas Karlsson <andreas@proxel.se>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Add missing CREATE TABLE IF NOT EXISTS table_name AS EXECUTE
 query;
Message-ID: <20190207013135.GD4074@paquier.xyz>
References: <2ddcc188-e37c-a0be-32bf-a56b07c3559e@proxel.se>
 <20190206114912.GE14980@paquier.xyz>
 <2c6f2b5b-a673-fd1c-ad9c-1c7676cee7d6@proxel.se>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="FFoLq8A0u+X9iRU8"
Content-Disposition: inline
In-Reply-To: <2c6f2b5b-a673-fd1c-ad9c-1c7676cee7d6@proxel.se>
Precedence: bulk


--FFoLq8A0u+X9iRU8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Feb 06, 2019 at 04:23:44PM +0100, Andreas Karlsson wrote:
> I added a test in create_table.sql where the test for the other form of CTAS
> IF NOT EXISTS is.

Okay, we can live with that.  Instead of a scan on pg_class, I would
have switched to a more simple thing like that for the PREPARE query:
PREPARE select1 AS SELECT 1 AS a;

Then it would be good to add a scan on the created relation after
running all the CREATE TABLE queries to make sure that it remains with
only one tuple.

> I have no idea if something like this should be back patched. I will add it
> to the commit fest either way so it is not lost.

I'd like to get that addressed before working on the other item
reshuffling the CTAS relation creation.  Let's wait for a couple of
days and see if folks have objections, and then revisit it at the
beginning of next week.  CTAS IF NOT EXISTS is supported down to
9.5 and is documented as such, and my proposal is to back-patch
accordingly.
--
Michael

--FFoLq8A0u+X9iRU8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlxbincACgkQnvQgOdby
QH18gg/9EEnqAmogxINTMgkl+O/Q2HHDn225ubxC9pEKwb036q6hZLiREkwkQZD2
WJU4o2KZfm01662YuDw8WOH/8lxTpgCLje4G+EVwugIUnfxbq6cbMhfSz6cKkPJG
6z8zh9yYyZ4qEaPuvXxM8wR/e1a7B4wtv4sCKemqvfrNABDCXkpjn6i+kCgiOkmY
3Wpj1GKGoNGerlAPHriQF+0xmMnk1CF4oXAgMABAAOc672s4XWuhKkcJvAZxUCq2
SpXqeIIgB6+5fdkb034D+eBvtolkaW/Or8Ep4buWwbHqYQPDBjBh1kPSAHmNvdBe
CHcVr4Odc4K6sGBPKZIVbNHBf2tEpywjRuYUCj5r/BfZQcK4bNhllrqsT7o+VT3K
NbPg2yK8EBWMbdoturP9AXmQJdn2fw3Uz+uNHdX8fLRTde3JHblJGhUsVtyQyuNX
4kJ/henrcIBILhd37nbzE0Re7YVjN7+8RI71WL85EXzkDnHrQ9LijFWkGLRiqrZS
vz9uJh5xraMeytGL0BDquXhoOdIXZ7nYPfB/z+1/gx1DGfyyN92ZxR8uUacZ9QXj
DYWsKdwdZJUKKAcolEfE1nDlHd49o/089++2n6ZFPl8gUMwFgPI7SI/i6jtJpwgC
o7HgxlbuAuZNGsaKFvUifiT806PRc0Z+SI41vx9SKK0oYWzrbV0=
=rQFn
-----END PGP SIGNATURE-----

--FFoLq8A0u+X9iRU8--