Date: Mon, 11 Feb 2019 17:04:45 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Geoghegan <pg@bowt.ie>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Fixing findDependentObjects()'s dependency on scan order
 (regressions in DROP diagnostic messages)
Message-ID: <20190211200445.GA30250@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <10442.1549914403@sss.pgh.pa.us>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On 2019-Feb-11, Tom Lane wrote:

> I've pushed this now.  I made one additional change, which was to fix
> things so that if both an INTERNAL and an EXTENSION dependency exist,
> the first loop will reliably complain about the EXTENSION dependency.
> It only takes one more if-test to do that now that we're postponing
> the error report till after the loop, and this way we don't need to
> split hairs about how likely it is for both to exist.
> 
> I think we're done with this thread, though I still need to look at
> the problem I complained of in <26527.1549572789@sss.pgh.pa.us>.

Thanks for taking care of this!

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services