Date: Tue, 12 Feb 2019 11:09:41 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	Daniel Gustafsson <daniel@yesql.se>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Reporting script runtimes in pg_regress
Message-ID: <20190212020941.GC1475@paquier.xyz>
References: <16646.1549770618@sss.pgh.pa.us>
 <E7790843-B885-492B-8537-CC9FB39D5F97@yesql.se>
 <11413.1549835730@sss.pgh.pa.us>
 <6f1657f9-c58c-ba28-0013-d36a6f6fd246@2ndquadrant.com>
 <6418.1549895430@sss.pgh.pa.us>
 <3e781ef4-04cb-5670-ee2b-7c0e99f72ece@lab.ntt.co.jp>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="R+My9LyyhiUvIEro"
Content-Disposition: inline
In-Reply-To: <3e781ef4-04cb-5670-ee2b-7c0e99f72ece@lab.ntt.co.jp>
Precedence: bulk


--R+My9LyyhiUvIEro
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 12, 2019 at 10:29:40AM +0900, Amit Langote wrote:
> On 2019/02/11 23:30, Tom Lane wrote:
>> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>>> Now that I see this in action, it makes the actual test results harder
>>> to identify flying by.  I understand the desire to collect this timing
>>> data, but that is a special use case and not relevant to the normal use
>>> of the test suite, which is to see whether the test passes.  Can we make
>>> this optional please?
>>=20
>> Well, I want the buildfarm to produce this info, so it's hard to see
>> how to get that without the timings being included by default.  I take
>> your point that it makes the display look a bit cluttered, though.
>> Would it help to put more whitespace between the status and the timing?
>=20
> +1.  Maybe, not as much whitespace as we get today between the test name
> and "... ok", but at least more than just a single space.

Sure, but do we need feedback immediately?  I am just catching up on
that, and I too find a bit annoying that this is not controlled by a
switch which is disabled by default.  It seems to me that this points
out to another issue that there is no actual way to pass down custom
options to pg_regress other than PG_REGRESS_DIFF_OPTS to control the
diff output format.  So we may also want something like
PG_REGRESS_OPTS.
--
Michael

--R+My9LyyhiUvIEro
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlxiKuUACgkQnvQgOdby
QH1VQA/+NYZNRGcVKy3Fcs/R1EHU16F8THDRADNwMn61rlA/4XkoEoLJzsWrMsPE
8fotbYDa65qqUXFbk3Ho0n9y/vEce18yod4YpqkUX2TUWtsY1sO8CM23IB28cSEt
Sgbl2XTagmN2HY1riQxVZKTNqItTFwPFyCWC2/N/DDsGfeGzreg+yff2Y2G+HIT4
QsReL/yVKnz20MwAqBNcdx74F44gUfoIZfMOuu0Bce38dejV1P10KVpx7nl/GgoV
ag4ou0tz+jUhHqwirQR62+gD+nnwEhacerK8gn/9AxjtEOep4EFr8vIHxodJl/o9
wuqHuoUEIotBE3SrHYzhofbEx0cg500SlrRTkLaFgboaNmt5a8Bt7m7niSY+a45f
yCf3MzKIvq0e5f1AvOS6reEMZAwhPFOyspiNlNPi4SNdRSLqSQAsvKszgoC6QbX6
GvZlhsRqFmz7Bipu9Y86gvWkmPF9El4vK/u0Gbl+bsfMmLUaPnzVSTd5ay6h9jl4
c8MZEWIFLvoZExzeKTZHusq9MEpg36FwNbYWUXThPoAhskeHEPIi9et1VT3fQdsI
GigFkEWf5bdtYp0hZwTgr+Kv9vnpaK8WH7XIRKn4Qi1FS0OT/buqbHIU8w1sPwPn
xYsugGcGYch1kSjFW6c7y7NRDMW7toATVgq+ebK1tRIV2XdCHPM=
=rkQf
-----END PGP SIGNATURE-----

--R+My9LyyhiUvIEro--