Date: Wed, 13 Feb 2019 16:18:29 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Thomas Munro <thomas.munro@enterprisedb.com>
Subject: Re: Using POPCNT and other advanced bit manipulation instructions
Message-ID: <20190213191829.GA19406@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAKJS1f-ukvN_OneocD_t_e=Ky1UoNX7hnnVU5m1b=kR_7DYciw@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On 2019-Feb-04, David Rowley wrote:

> On Fri, 1 Feb 2019 at 11:45, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> >
> > I only have cosmetic suggestions for this patch.  For one thing, I think
> > the .c file should be in src/port and its header should be in
> > src/include/port/, right beside the likes of pg_bswap.h and pg_crc32c.h.
> 
> I've moved the code into src/port and renamed the file to pg_bitutils.c

I've pushed this now.  Let's see what the buildfarm has to say about it.

> I've compiled and run make check-world on Linux with GCC7.3 and
> clang6.0. I've also tested on MSVC to ensure I didn't break windows.
> It would be good to get a few more people to compile it and run the
> tests.

That's what the buildfarm is for ...

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services