Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1guicD-0002vM-OD
	for pgsql-hackers@arkaria.postgresql.org; Fri, 15 Feb 2019 18:53:37 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1guicC-0000NK-B9
	for pgsql-hackers@arkaria.postgresql.org; Fri, 15 Feb 2019 18:53:36 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1guicC-0000ND-02
	for pgsql-hackers@lists.postgresql.org; Fri, 15 Feb 2019 18:53:36 +0000
Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1guic8-00082M-SF
	for pgsql-hackers@postgresql.org; Fri, 15 Feb 2019 18:53:34 +0000
Received: by mail-qt1-x842.google.com with SMTP id v10so12069405qtp.8
        for <pgsql-hackers@postgresql.org>;
 Fri, 15 Feb 2019 10:53:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition
         :content-transfer-encoding:in-reply-to:user-agent;
        bh=/bm5MBJeNgMjIYmvnHfjyTiHsDpxRWDE9onPWdBLJBs=;
        b=HEf+kaUm6u2blxOqqEh6BqM3QFybB5lmyefEVilXQTx6DR8eY+nHVOJI25c/smZ6+J
         R8dLapXEgOgwLW7asbNGynA+T0wBoWgrCKCaHuVqX+BqknfDr5L/jWvrvkPHIMtYxyiU
         uu4UOgtrdNsNBrXDrpJkKUtkI5TmL9old4z+8DH7KjxE/wn2pf4AsSLQjeCuvi9EZuAV
         jKn4Vq6bIpjJjl4VOED8D2pSTvuzA/1z+5EoujSbaRgk3MnbwN5gMEXHIggAiwXyB0Sq
         0tcq3YjvBKXN0zOu+0vq42HqFkz5hvXGzrAU35KmOdzuGbrzt0dcwXT98GpsNFrcoOFD
         sbjQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition:content-transfer-encoding:in-reply-to
         :user-agent;
        bh=/bm5MBJeNgMjIYmvnHfjyTiHsDpxRWDE9onPWdBLJBs=;
        b=DR60gVcpm7BMgRFRr6OyNL95uB6rlT8td4CoA4JnKj2jFsLfftBAUFUvtXrF5SRuv7
         iMdX/157QJAzVLNfBC6F+xv/GKCsLyE5S8tDQjzz8t3NQGnpTNMrFGKHnqIHhKcqxlw0
         /y8dDrwyrE3m04okQr9JxADXg89CdY1zsnRhGKNmx9xlqD38CWoSuNWz70EmXtUYARAS
         xtt0jKxTetvoJMHUNQHYorsXTpuHOrUpAF16MLmRrrkMmrdvYaVl4i+d7QoNagSj/OF6
         4Mnv6q4mvJLIJiNT5IiNrUd9vlU9uzAR6fvmYQx3DGG1hH3IhZ0bFxXW7rQXsajPlouu
         I7tA==
X-Gm-Message-State: AHQUAuYNoUarfWVZQbJ4z8m3yTmzX53uWY/qBWj/tYuz+rvNjrIfnRuU
	z7KDkNylfrC3XS9VLesyv7HaMQ==
X-Google-Smtp-Source: 
 AHgI3IYNwscpWwTlJMHJpPa2Z2ZUj6DSVkIimC8GIo+5mSFJaNGNsJmqA1B7g3wUbymxI4PBTpnN9A==
X-Received: by 2002:ac8:8e4:: with SMTP id y33mr8664689qth.311.1550256812111;
        Fri, 15 Feb 2019 10:53:32 -0800 (PST)
Received: from nimloth.alvh.no-ip.org ([190.121.29.3])
        by smtp.gmail.com with ESMTPSA id j8sm2090043qtn.6.2019.02.15.10.53.31
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Fri, 15 Feb 2019 10:53:31 -0800 (PST)
Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000)
	id 1482E1238DD; Fri, 15 Feb 2019 15:53:28 -0300 (-03)
Date: Fri, 15 Feb 2019 15:53:28 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>,
	tomas.vondra@2ndquadrant.com, ah@cybertec.at, magnus@hagander.net,
	robertmhaas@gmail.com, tgl@sss.pgh.pa.us,
	pgsql-hackers@postgresql.org
Subject: Re: shared-memory based stats collector
Message-ID: <20190215185328.GA29663@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190215171655.ioxlfm5a2rrl6dzv@alap3.anarazel.de>
User-Agent: Mutt/1.9.4 (2018-02-28)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

On 2019-Feb-15, Andres Freund wrote:

> It's fine to do such renames, just do them as separate patches. It's
> hard enough to review changes this big...

Talk about moving the whole file to another subdir ...

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services