Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gv5N8-0002gv-5U for pgsql-hackers@arkaria.postgresql.org; Sat, 16 Feb 2019 19:11:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gv5M6-0006ek-66 for pgsql-hackers@arkaria.postgresql.org; Sat, 16 Feb 2019 19:10:30 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gv5M5-0006eR-JA for pgsql-hackers@lists.postgresql.org; Sat, 16 Feb 2019 19:10:29 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gv5M2-00018W-P6 for pgsql-hackers@lists.postgresql.org; Sat, 16 Feb 2019 19:10:28 +0000 Received: by mail-pf1-x441.google.com with SMTP id g6so6446518pfh.13 for ; Sat, 16 Feb 2019 11:10:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yFruf0EMl8dFHKrZn6N5+ILklGkb4/dHfmBVZ5a/MbE=; b=Dv/23eImtIJWuSu1SGP4hQaXDFVDWjINjI9dyAy315u1q3YcIkqSxeMK6xHiRUuU/6 CtggC4aiGJOluoN3FdOLMtKpGx8cDymTIEgbNiMyu6oNQyjK9XgOSXnRgUY3tYGKxVuL YPKF8RRgYmntKEIt2fdLBy7hZiJA7w0pxRycw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yFruf0EMl8dFHKrZn6N5+ILklGkb4/dHfmBVZ5a/MbE=; b=Tk1VAYlW15tKr4bMmChu+4zmnPJFiKvEWMfQrf1MEz9G+PFvtJ04wkhNCZ3X31MM8+ KB98+8BdiE2CDXOnC04WrtowRyGWBxqzfKAjnUVPV/E7MttWfWhvYhw2BamqP/AJGK59 dvmQp7Nm120V67KDG5HFKIKwUV8cnXTXy0wm4vwwiFLSnILpPKv7SS0KW1sCded2xmiv w6UjttFEwah/l++aRKeh3++Zhc9aOHdBQStAUjq2DKjHJvNYGKZaT8pJ0oTa81QgLy0c hZEy1sBDx3n+sk4QbcyB+kQ2jHe1tjyH16Rf+Y538sU9AVTNTSdzJFd9CUYT4D2GAbMM StCQ== X-Gm-Message-State: AHQUAuaP8SMrGi4DirW+vsArgGHkI1cgzaTzsPLKCv0DiMlRU64EFIDu J1ioDpJWvZfPbYwbzy8r5Hiodg== X-Google-Smtp-Source: AHgI3IZSDLnVIYMeeCMuk3TbMYyLKFdwmVts4qIJv1LoYxPak+LOIrlk0Fo45R0flaWHfIeweKlXtQ== X-Received: by 2002:a62:43c5:: with SMTP id l66mr16299437pfi.77.1550344225208; Sat, 16 Feb 2019 11:10:25 -0800 (PST) Received: from rfd.leadboat.com (108-233-125-46.lightspeed.sntcca.sbcglobal.net. [108.233.125.46]) by smtp.gmail.com with ESMTPSA id v11sm15674342pfa.49.2019.02.16.11.10.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Feb 2019 11:10:23 -0800 (PST) Date: Sat, 16 Feb 2019 11:10:21 -0800 From: Noah Misch To: Tom Lane Cc: Andres Freund , pgsql-hackers@lists.postgresql.org, Alvaro Herrera , David Fetter , Andrew Gierth , pgsql-hackers@postgresql.org, daniel@yesql.se, michael@paquier.xyz Subject: Re: Synchronize with imath upstream Message-ID: <20190216191021.GC1212026@rfd.leadboat.com> References: <20190205234750.GA2774@alvherre.pgsql> <23413.1549466124@sss.pgh.pa.us> <20190207055011.GB392703@rfd.leadboat.com> <19483.1549552325@sss.pgh.pa.us> <20190208043844.GA562856@rfd.leadboat.com> <28536.1549601778@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <28536.1549601778@sss.pgh.pa.us> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Thu, Feb 07, 2019 at 11:56:18PM -0500, Tom Lane wrote: > Noah Misch writes: > > On Thu, Feb 07, 2019 at 10:12:05AM -0500, Tom Lane wrote: > >> I have no particular opinion on whether pgindent should be part of the > >> mix for imath, but I do strongly recommend setting up and documenting a > >> reproducible import process, as I did for src/timezone. > > > Good idea. I've modified the imath.c header comment to take the form of an > > import process; see attached imath1.29-pgedits-v2.patch. > > Maybe easier to keep the instructions in a separate README file? Most imath.c patches have cause to update those lines, and patches to other files almost never do. Hence, I think hackers are more likely to find and update those lines in imath.c. I would choose a README if concerns weren't concentrated in one file. > (I don't see a need to put a PG copyright in this file, when the > mods from upstream are this small.) The tree has been inconsistent about that, which is okay. I was mimicking src/port/strlcpy.c. Others, e.g. src/port/crypt.c, haven't added a copyright.