Date: Sat, 16 Feb 2019 13:40:23 -0800
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@lists.postgresql.org,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	David Fetter <david@fetter.org>,
	Andrew Gierth <andrew@tao11.riddles.org.uk>,
	pgsql-hackers@postgresql.org, daniel@yesql.se, michael@paquier.xyz
Subject: Re: Synchronize with imath upstream
Message-ID: <20190216214023.GD1212026@rfd.leadboat.com>
References: <20190205234750.GA2774@alvherre.pgsql>
 <FB934CD7-B508-4523-B920-F0EE9CCB1756@anarazel.de>
 <23413.1549466124@sss.pgh.pa.us>
 <20190207055011.GB392703@rfd.leadboat.com>
 <19483.1549552325@sss.pgh.pa.us>
 <20190208043844.GA562856@rfd.leadboat.com>
 <28536.1549601778@sss.pgh.pa.us>
 <20190216191021.GC1212026@rfd.leadboat.com>
 <7045.1550344370@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7045.1550344370@sss.pgh.pa.us>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk

On Sat, Feb 16, 2019 at 02:12:50PM -0500, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > On Thu, Feb 07, 2019 at 11:56:18PM -0500, Tom Lane wrote:
> >> Maybe easier to keep the instructions in a separate README file?
> 
> > Most imath.c patches have cause to update those lines, and patches to other
> > files almost never do.  Hence, I think hackers are more likely to find and
> > update those lines in imath.c.  I would choose a README if concerns weren't
> > concentrated in one file.
> 
> Fair enough, objection withdrawn.

Pushed, but it broke dory.  Will fix.