Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gvXQr-0007qq-9O for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Feb 2019 01:09:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gvXQp-00039f-U9 for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Feb 2019 01:09:15 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gvXQp-00039Y-Eu for pgsql-hackers@lists.postgresql.org; Mon, 18 Feb 2019 01:09:15 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gvXQi-0006cr-Vr for pgsql-hackers@lists.postgresql.org; Mon, 18 Feb 2019 01:09:14 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 2682221C8E; Sun, 17 Feb 2019 20:09:08 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 17 Feb 2019 20:09:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=V1DUzCOb0VJfv7wCy5HGeUkbm9m daC7tj5EvtdIqfjI=; b=VaaZcZhx8jn7LI/tPEkZn95V2nH/O9OP1TwvzBFobka M5UOH3GpN6Urcx3hpBnYoAUBe2jBuWZ7P5+ICmHIiMnkpT+nR8DIrIzi2zEuORy5 X3wnM+OjkXdY8E4oalpGIyazF8D4fNgC1rMdGRTRjIvAbAoKj4E+Tr1taSlxetlE 86WTvBMZZDDnPTJuN4Al3Ow3wxvOW8815/qYLGLIrhS3rcFOsQr4ss8W4W/LsKFn wiMMfmZnd08kMwZ233kf4rQJxqZcdTvo0WU168ixfIO6EMCkq9mSKJegHx3OF8Y7 i1RPwQUVDdkm18czjk1gAB8IEmBe9aYIMJJLsvZo6Ww== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=V1DUzC Ob0VJfv7wCy5HGeUkbm9mdaC7tj5EvtdIqfjI=; b=UIX63dTTxPjLffPteeKXqi DxNckCvegdal0yY9UCUWl0B15BFKTSLh78hgBviHtksrN4qrOhOJFMr5lKVYZhFG EqbU7RbiCu0x9L1iA+XiLwwUPSTwGAvDGRNgqLsCuoQNpryXkE0PKzOtN3xMcTgb 1IJZZv5DKl7vvLZHZJ7cN7ozs6kkcWf/17Lqo1WL7qT2m4HjuFaYpkL04o06MjkB P0vVzhfxem5nzJ0o1Y/F+8tJyxilwuH9zvUgxHUGHpz4QEvbft+N7IVLjIgyAx51 A23vRYpVyJ7xDO22GOaChRxT1ImuLFsS+LyYj7EWeDx6a+oH1ihGf2+9MoCVVqJA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrudduvddgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdejtd dmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgt hhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqne cukfhppeeiuddrvdduhedrudefjedrudeivdenucfrrghrrghmpehmrghilhhfrhhomhep mhhitghhrggvlhesphgrqhhuihgvrhdrgiihiienucevlhhushhtvghrufhiiigvpedu X-ME-Proxy: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id BA4FAE4016; Sun, 17 Feb 2019 20:09:05 -0500 (EST) Date: Mon, 18 Feb 2019 10:09:02 +0900 From: Michael Paquier To: Arthur Zakirov Cc: Grigory Smolkin , pgsql-hackers@lists.postgresql.org Subject: Re: [PATCH] xlogreader: do not read a file block twice Message-ID: <20190218010902.GF1864@paquier.xyz> References: <2ddf4a32-517e-d6f4-d992-4a63b6035bfd@postgrespro.ru> <87e30af6-f85a-dc95-4574-95cded028786@postgrespro.ru> <20190212042300.GL1475@paquier.xyz> <1fa0c9fe-32a5-3ebd-e9c2-b5e2c9abc03e@postgrespro.ru> <20190214065156.GE2366@paquier.xyz> <7eaccd53-ea89-e0cf-b718-80e3f3fc3abf@postgrespro.ru> <20190214230616.GA2240@paquier.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uTRFFR9qmiCqR05s" Content-Disposition: inline In-Reply-To: <20190214230616.GA2240@paquier.xyz> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --uTRFFR9qmiCqR05s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 15, 2019 at 08:06:16AM +0900, Michael Paquier wrote: > Thanks, I see what you have done. I cannot comment if your shortcut > is actually fully correct based on my knowledge of this code, but > things cannot be in the best conditions without having the WAL reader > handle properly the limits. So I am planning to commit what you > propose after an extra pass on it in the next couple of days or so. And done, after doing and extra pass, doing more testing using by own plugins, pg_waldump and more fancy stuff with a primary/standby and pgbench. -- Michael --uTRFFR9qmiCqR05s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlxqBa4ACgkQnvQgOdby QH2h7BAAk8l+xqiRhyIM2PYKjllnQmuhBMrRA6LeBZ9M6ramio7WRAlDrc0nR55S yoGQIUyfwBQ0UcgBizwLOW1WDv+prfWdc7lycI+ElwQcC/tB7klAbnMBQwfJSTBC 9XIQIPZU1yJSPo9f+zsgBmJOxIurNOtm3MTXJpaWFhBO7blzluye3OWrK02JbI3R zJUfBx0BY9PXi7hqn4/dx5+6jha2UvQ+KCqjJG+bT329LLUm7vGuJLeqOOnnnCvj NWwgwxHf6Qpm85uB1OYO2CqAeiMgbD6HAbqklRus1j5IHdQrQlT+TyJz6LIcSzrm CTtgV0lMh2H0NxtZ/G7KtXlc3ipYQw8TLvHythTd7KdY60tYe09kqBY5Dkbeo1Br NZb62VNqRGd1VdAkZyj56KlMmn85WKscmoy5jBSlQoa9V4vpvtqi90J3a6IgS3Zc jNIGIyXUrAsE3H+yWv4U8TIbhaMVSTodeM1J3srXMjAED5LanCCksLfiyuHBaCns c3QboSDQj6vP29BnzalKm9zHEdbahDWQ/ASPxt3GOrct1+8nzSoSm/hUDulEefYw BshCdWmXLryK5eqA1/6Pds8ncbO27c/8E8U09LJzUG6uRlF/mFWB04Cdd0ixTEyO 9UKEfjcuol9IHWeiwYB1j8JZhF6u60I5ZSp6g+qB3MR/HGumvY4= =LFIQ -----END PGP SIGNATURE----- --uTRFFR9qmiCqR05s--