Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gvjF6-0002j5-Ae
	for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Feb 2019 13:45:56 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gvjF3-0003xX-JX
	for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Feb 2019 13:45:53 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1gvjF3-0003t4-5H
	for pgsql-hackers@lists.postgresql.org; Mon, 18 Feb 2019 13:45:53 +0000
Received: from mail-qk1-x743.google.com ([2607:f8b0:4864:20::743])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1gvjEv-0001kU-FM
	for pgsql-hackers@postgresql.org; Mon, 18 Feb 2019 13:45:52 +0000
Received: by mail-qk1-x743.google.com with SMTP id o125so9977889qkf.3
        for <pgsql-hackers@postgresql.org>;
 Mon, 18 Feb 2019 05:45:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition
         :content-transfer-encoding:in-reply-to:user-agent;
        bh=79eo+DhCFLE5Mwu81WMTm72bjG6WS+9RDp6am+1r1ZQ=;
        b=v0SZM15e5/EBl1/98XsP1W6lW69GsE1dFnEJDRu+LGOnNYCEjI4xAaNbRpfFKEDH5C
         4W01zLauKTmoULJacYXvdmdKw1WD/14psP1bAi0rislu6frSGZvt5VGCPerVDEe/ApFE
         bKwUWO6e3/IvYvqSr18hEEW4rn+KYwfifelXyvoO70VxLBzebaRJF5xlAVAJUgGADNUx
         CrbSd9gm7GKJa803grfvg7e6dNxeePtXcjlvl8C3wOJVV8F9il/CpcnqrsJzx5vJGkdO
         rCbxDjVT8DdXxOm8Q2Qi+zYQmkLlNA4CeS/K3yNYR/40Ie8M/0dqyy3VFRsRskHHlAxx
         1JIg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition:content-transfer-encoding:in-reply-to
         :user-agent;
        bh=79eo+DhCFLE5Mwu81WMTm72bjG6WS+9RDp6am+1r1ZQ=;
        b=hPQ+ct4N/yT+B0/cb2M1qKOJfIXD+uFajjkO0MCRW7355LHkOwNkGnwCGiOgkNnjKv
         krLVELK1pKyM2JWlvKxpMUCrxZnq55YWmFVqfdqc/Ti6LjeWP+NWAdNwpVGtceOp4D6R
         nkaBw6icZcZazwnQkhyu3fRArKWWP8EhI9O2QoLRU6QQRWxMpg2+8x2WxFnJtB4dpa/e
         3hQ55wXl74q5MnrgC30gEpzY6+Et0pmHKpEM4vSG6f92wVZvB4r54mDv6JwVS+oEBcEZ
         lz4WsM2o3oRLnolo5cxP7njEJLEndiun14Q1xloYftl8PJNc2wdVuufJA6kiYfnyB8R+
         Be1g==
X-Gm-Message-State: AHQUAuY9/ixrp6oaD9PfnOnfbrxZxpJRtITArA70gyxpZrbOFZGKmcRC
	mU1U0GjsqHxotCWZFH9VtM/THuCKtHg=
X-Google-Smtp-Source: 
 AHgI3IZ2xtjvQm7lQhSEYGI41WsB52ACW9+vXFGx2y77zTubiUY2oHdfh3vPojN0BEDUudJkqBxWQg==
X-Received: by 2002:a37:8e81:: with SMTP id
 q123mr16744518qkd.34.1550497543395;
        Mon, 18 Feb 2019 05:45:43 -0800 (PST)
Received: from nimloth.alvh.no-ip.org ([186.11.95.81])
        by smtp.gmail.com with ESMTPSA id
 k127sm7053536qkf.4.2019.02.18.05.45.42
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Mon, 18 Feb 2019 05:45:42 -0800 (PST)
Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000)
	id 578EB1245A9; Mon, 18 Feb 2019 10:45:38 -0300 (-03)
Date: Mon, 18 Feb 2019 10:45:38 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Antonin Houska <ah@cybertec.at>, Bruce Momjian <bruce@momjian.us>,
	pgsql-hackers@postgresql.org
Subject: Re: Incorrect visibility test function assigned to snapshot
Message-ID: <20190218134538.GA809@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190218040120.GI15532@paquier.xyz>
User-Agent: Mutt/1.9.4 (2018-02-28)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

On 2019-Feb-18, Michael Paquier wrote:

> On Fri, Feb 15, 2019 at 01:01:29PM +0100, Antonin Houska wrote:
> > As for the bug fix, I think the additional assignment does not make things
> > worse because SnapBuildInitialSnapshot() already does overwrite some fields:
> > "xip" and "xnt".
> 
> Ah, right.  I somewhat missed that.  Let's move on with merging your
> patch then.  Are there any objections about that?

None here.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services