Date: Mon, 18 Feb 2019 13:49:02 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: Alexey Kondratov <a.kondratov@postgrespro.ru>,
	Andrey Borodin <x4mmm@yandex-team.ru>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Dmitry Dolgov <9erthalion6@gmail.com>,
	Michael Paquier <michael@paquier.xyz>, vladimirlesk@yandex-team.ru,
	dsarafan@yandex-team.ru
Subject: Re: [Patch] pg_rewind: options to use restore_command from
 recovery.conf or command line
Message-ID: <20190218164902.GA7979@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190218163650.y4jhieizrajfh42c@alap3.anarazel.de>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On 2019-Feb-18, Andres Freund wrote:

> Hi,
> 
> On 2019-02-18 16:26:55 +0300, Alexey Kondratov wrote:
> > Hi Andres,
> > 
> > Thank you for your feedback.
> > 
> > On 16.02.2019 6:41, Andres Freund wrote:
> > > It sounds like a seriously bad idea to use a different parser for
> > > pg_rewind.  Why don't you just use postgres for it? As in
> > > /path/to/postgres -D /path/to/datadir/ -C shared_buffers
> > > ?

Eh, this is what I suggested in this thread four months ago, though I
didn't remember at the time that aaa6e1def292 had already introduced -C
in 2011.  It's definitely the way to go ... all this messing about with
the parser is insane.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services