Date: Thu, 21 Feb 2019 17:11:24 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: restrict pg_stat_ssl to superuser?
Message-ID: <20190221081124.GS15532@paquier.xyz>
References: <63117976-d02c-c8e2-3aef-caa31a5ab8d3@2ndquadrant.com>
 <20190212064007.GN1475@paquier.xyz>
 <71319f2d-a073-0499-4562-6003e026307e@2ndquadrant.com>
 <20190218035813.GH15532@paquier.xyz>
 <1d1bf3a7-955e-ce6b-de99-b900136ca789@2ndquadrant.com>
 <3018acd9-e5d8-1e85-5ed7-47276cd77569@2ndquadrant.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="KISHs/FnjYvFOG5B"
Content-Disposition: inline
In-Reply-To: <3018acd9-e5d8-1e85-5ed7-47276cd77569@2ndquadrant.com>
Precedence: bulk


--KISHs/FnjYvFOG5B
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Feb 20, 2019 at 11:51:08AM +0100, Peter Eisentraut wrote:
> So here is a patch doing it the "normal" way of nulling out all the rows
> the user shouldn't see.

That looks fine to me.

> I haven't found any documentation of these access restrictions in the
> context of pg_stat_activity.  Is there something that I'm not seeing or
> something that should be added?

Yes, there is nothing.  I agree that it would be good to mention that
some fields are set to NULL and only visible to superusers or members of
pg_read_all_stats with a note for pg_stat_activity and
pg_stat_get_activity().  Here is an idea:
"Backend and SSL information are restricted to superusers and members
of the <literal>pg_read_all_stats</literal> role. Access may be
granted to others using <command>GRANT</command>.

Getting that back-patched would be nice where pg_read_all_stats was
introduced.
--
Michael

--KISHs/FnjYvFOG5B
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlxuXSsACgkQnvQgOdby
QH2KaA/+OkIW60ZNPIhc0G6PV0UEKUR7ijsTdKuGjo/FuD0VUFQqKR5mXkphx2LS
nScY1/0FtnPyfzd2bfYR0JFJKSiu6CDM3IAVrJSXDxidMxvDXGq76VYEoURaa5VY
auDWRg02NezCuH06vsfeJpmmxDxo67ESjWdfXIY4SuWQmosdcjIlMgy7UCosFdmC
HEsHIrNCwicR8OYQIbSMzJCa07oSi71RRNWCWxzGOFyH6cwB1nuX0R8Ey2hOvFKf
g6DRYuuaYmsupMGlGtXAVZTQYNm6PWtsYJRoqtqL+/JHHRexZHpmYi12DzloKUt3
GA6qhTEdcb6+txP+5zJDa9Iu10yas99e46FN2BDlEUjX/B2QpudQvUmP742xrDvo
cPl++T+SAZrVknqNnSDxpLrFIY/8ue0geKiuIy8v7nW5lAGsaVWagHIys8ae2K7n
c7jl2S6mLXKvbGz7DVTBo2BsYpYb0lGq2PQYKMZeAG3+QVDdcMzMYdEJvv8H9RZK
gPpakf3sNLBH6c3OHF+bsCU1jbpRjQHSbRZEyu5l7YY0UG9QntPecVAXJXi3Asjy
HDcIhszorLxsJH6pg5dq93xYlm6qN/Fld55nIh7fVcDT2JkTn5gQfToxm+jFSzAx
0SDNTuQUmLVs7Kj+dnKEZ3DW/j8rY9MQhQopondvaXgNiU/c5g8=
=YW/a
-----END PGP SIGNATURE-----

--KISHs/FnjYvFOG5B--