pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedBRIN summarize autovac_report_workitem passes datname as relname
3+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2019-02-22 630de1131d 398cc6fb93 98098faaff Report correct name in autovacuum "work items" activity
* BRIN summarize autovac_report_workitem passes datname as relname
@ 2019-02-20 18:55 Justin Pryzby <pryzby@telsasoft.com>
2019-02-20 21:19 ` Re: BRIN summarize autovac_report_workitem passes datname as relname Euler Taveira <euler@timbira.com.br>
0 siblings, 1 reply; 3+ messages in thread
From: Justin Pryzby @ 2019-02-20 18:55 UTC (permalink / raw)
To: pgsql-hackers
src/backend/postmaster/autovacuum.c declares:
|static void
|autovac_report_workitem(AutoVacuumWorkItem *workitem,
| const char *nspname, const char *relname)
But calls it like:
| cur_relname = get_rel_name(workitem->avw_relation);
| cur_nspname = get_namespace_name(get_rel_namespace(workitem->avw_relation));
| cur_datname = get_database_name(MyDatabaseId);
| if (!cur_relname || !cur_nspname || !cur_datname)
| goto deleted2;
|
| autovac_report_workitem(workitem, cur_nspname, cur_datname);
So I see stuff like:
|check_pg - txn_time POSTGRES_TXN_TIME OK: DB main longest txn: 164s PID:10697 database:main username: query:autovacuum: BRIN summarize public.main 1028223
I guess it should be database.namespace.relname ?
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: BRIN summarize autovac_report_workitem passes datname as relname
2019-02-20 18:55 BRIN summarize autovac_report_workitem passes datname as relname Justin Pryzby <pryzby@telsasoft.com>
@ 2019-02-20 21:19 ` Euler Taveira <euler@timbira.com.br>
2019-02-22 16:01 ` Re: BRIN summarize autovac_report_workitem passes datname as relname Alvaro Herrera <alvherre@2ndquadrant.com>
0 siblings, 1 reply; 3+ messages in thread
From: Euler Taveira @ 2019-02-20 21:19 UTC (permalink / raw)
To: Justin Pryzby <pryzby@telsasoft.com>; +Cc: pgsql-hackers
Em qua, 20 de fev de 2019 às 15:56, Justin Pryzby
<pryzby@telsasoft.com> escreveu:
>
> I guess it should be database.namespace.relname ?
>
Yup. It is an oversight in 7526e10224f0792201e99631567bbe44492bbde4.
--
Euler Taveira Timbira -
http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: BRIN summarize autovac_report_workitem passes datname as relname
2019-02-20 18:55 BRIN summarize autovac_report_workitem passes datname as relname Justin Pryzby <pryzby@telsasoft.com>
2019-02-20 21:19 ` Re: BRIN summarize autovac_report_workitem passes datname as relname Euler Taveira <euler@timbira.com.br>
@ 2019-02-22 16:01 ` Alvaro Herrera <alvherre@2ndquadrant.com>
0 siblings, 0 replies; 3+ messages in thread
From: Alvaro Herrera @ 2019-02-22 16:01 UTC (permalink / raw)
To: Euler Taveira <euler@timbira.com.br>; +Cc: Justin Pryzby <pryzby@telsasoft.com>; pgsql-hackers
On 2019-Feb-20, Euler Taveira wrote:
> Em qua, 20 de fev de 2019 às 15:56, Justin Pryzby
> <pryzby@telsasoft.com> escreveu:
> >
> > I guess it should be database.namespace.relname ?
> >
> Yup. It is an oversight in 7526e10224f0792201e99631567bbe44492bbde4.
Oops. Pushed fix. Thanks for reporting.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2019-02-22 16:01 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-02-20 18:55 BRIN summarize autovac_report_workitem passes datname as relname Justin Pryzby <pryzby@telsasoft.com>
2019-02-20 21:19 ` Euler Taveira <euler@timbira.com.br>
2019-02-22 16:01 ` Alvaro Herrera <alvherre@2ndquadrant.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox