Date: Wed, 27 Feb 2019 14:21:52 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Jeff Janes <jeff.janes@gmail.com>
Cc: Andres Freund <andres@anarazel.de>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	Robert Haas <robertmhaas@gmail.com>,
	Haribabu Kommi <kommi.haribabu@gmail.com>,
	Amit Khandekar <amitdkhan.pg@gmail.com>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	Amit Kapila <amit.kapila16@gmail.com>
Subject: Re: TupleTableSlot abstraction
Message-ID: <20190227052152.GA3540@paquier.xyz>
References: <20180220224318.gw4oe5jadhpmcdnm@alap3.anarazel.de>
 <20181113233021.nckxp4kalaqzx7ag@alap3.anarazel.de>
 <20181117004642.hushozrhxs7v72qo@alap3.anarazel.de>
 <CAMkU=1xZXtz3mziPEPD2Fubbas4G2RWkZm5HHABtfKVcbu1=Sg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="OXfL5xGRrasGEqWY"
Content-Disposition: inline
In-Reply-To: 
 <CAMkU=1xZXtz3mziPEPD2Fubbas4G2RWkZm5HHABtfKVcbu1=Sg@mail.gmail.com>
Precedence: bulk


--OXfL5xGRrasGEqWY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Feb 16, 2019 at 05:07:44PM -0500, Jeff Janes wrote:
> By blind analogy to the changes made to matview.c, I think that createas.c
> is missing a heap_freetuple, as attached.

I think that you are right.  CTAS and materialized views share a lot
when it comes to relation creation and initial table loading.  I have
reproduced the leak and could notice that your fix is correct.  So
committed.
--
Michael

--OXfL5xGRrasGEqWY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlx2HnAACgkQnvQgOdby
QH0KpBAApVqKCb1TogeaxChKyqCwXobWRI/w8RMPbcwojuF7u0/PurX21u7Urh3n
OdkFxD7dYetSVPku8ZvbHhOZtERnoVxnUydxBxxb9imE2gSqpjpRzZEppxsOsq++
twExxUHJ4/5c9gADF4Hkamu/CRUpEWCTYA3NNU1rEx7VuYlqHLw/oCwN4WKv2EAD
Fvr4Pk84aMXnmXI3ZAUPgUFvAO1/qcwuZVdtKZM37lfH4ffIEIP/WD/zOgO4/cmy
2Sj/fkfZh7DiT0cWVSCPqnBGQwkc0+SM4CVSRJkWWax3o3cLIsQp9jUpDoEVgHrI
+oUxNfwFTkGPWCs8QwfKJzUsutluPuphLBhADzFjGPLEugZh2JBmY/qTR5xcWRs4
rO06Lgnkz47uKogoyj6U8h+sjB3m9Aq6XyZccw4Txrmz8tDHafCElaVvaz2NmRBW
5bmHeMkLINx3KQ2j9amnK14JmBOdNMM/WrDDwhjBfuQueTBcbFRziXyqGYs4uzvg
/eDLes7TrgoxaNete4PujeoWtTuMehJV+fuglJeK8vTO/273GZR9pxMnxANvll+t
JqdKJKZ/dxAsox5nMHsURb6PzT11NZx+DUCjuq92DsJL79I//iN9WvGwABkMESGF
vU5vi/T+9Wzb6i8v/6XcCT1skOmJmYbofUy9sbgp7u5S8mISvWI=
=TU0K
-----END PGP SIGNATURE-----

--OXfL5xGRrasGEqWY--