Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gzosl-00087k-KT for pgsql-hackers@arkaria.postgresql.org; Fri, 01 Mar 2019 20:35:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gzosk-00072C-1X for pgsql-hackers@arkaria.postgresql.org; Fri, 01 Mar 2019 20:35:46 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gzosj-00070i-Pd for pgsql-hackers@lists.postgresql.org; Fri, 01 Mar 2019 20:35:45 +0000 Received: from smtp-fw-33001.amazon.com ([207.171.190.10]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gzosg-0006U2-IF for pgsql-hackers@postgresql.org; Fri, 01 Mar 2019 20:35:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1551472542; x=1583008542; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=goVrIP/rLuaNJU4dN0ArzxsAcIzl/TnGtt9lFjZZczg=; b=ue0YorLU2YxZRNZ0+nvyG9TfD68oiEMjqannOzAzIwlXXf8ETdtW/ia8 zNJ81UQHhwu7i8P6fhnTNgkuD7oEi8W618Y6IljaWZY1Vq76HdBXy6wEJ dOHSTT6yz8MaK1oO78krdKDWyeZ89bSrEjtR/OXKTYwnvHlhjxJlO6Dml g=; X-IronPort-AV: E=Sophos;i="5.58,429,1544486400"; d="scan'208";a="786078478" Received: from sea3-co-svc-lb6-vlan2.sea.amazon.com (HELO email-inbound-relay-1d-37fd6b3d.us-east-1.amazon.com) ([10.47.22.34]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 01 Mar 2019 20:35:37 +0000 Received: from EX13MTAUWC001.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan3.iad.amazon.com [10.40.159.166]) by email-inbound-relay-1d-37fd6b3d.us-east-1.amazon.com (8.14.7/8.14.7) with ESMTP id x21KZZov122505 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 1 Mar 2019 20:35:36 GMT Received: from EX13D05UWC002.ant.amazon.com (10.43.162.92) by EX13MTAUWC001.ant.amazon.com (10.43.162.135) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 1 Mar 2019 20:35:34 +0000 Received: from f01898859afd.ant.amazon.com (10.43.160.245) by EX13D05UWC002.ant.amazon.com (10.43.162.92) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 1 Mar 2019 20:35:34 +0000 Date: Fri, 1 Mar 2019 12:35:33 -0800 From: Shawn Debnath To: Robert Haas CC: Andres Freund , Thomas Munro , Thomas Munro , Dmitry Dolgov <9erthalion6@gmail.com>, PostgreSQL-development Subject: Re: Refactoring the checkpointer's fsync request queue Message-ID: <20190301203533.GB4664@f01898859afd.ant.amazon.com> References: <20190222230916.5mfsqn3oesd2nxiz@alap3.anarazel.de> <20190222234549.GA7397@f01898859afd.ant.amazon.com> <20190222235742.4oed46wocpjfpoa5@alap3.anarazel.de> <20190227212653.GA7171@f01898859afd.ant.amazon.com> <20190301174256.3um2t73wycsywrur@alap3.anarazel.de> <20190301193558.GA4664@f01898859afd.ant.amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-Originating-IP: [10.43.160.245] X-ClientProxiedBy: EX13D21UWA001.ant.amazon.com (10.43.160.154) To EX13D05UWC002.ant.amazon.com (10.43.162.92) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Fri, Mar 01, 2019 at 03:03:19PM -0500, Robert Haas wrote: > On Fri, Mar 1, 2019 at 2:36 PM Shawn Debnath wrote: > > I disagree, at least with combining and retaining enums. Encoding all > > the possible request types with the current, planned and future SMGRs > > would cause a sheer explosion in the number of enum values. > > How big of an explosion would it be? 4 enum values x # of smgrs; currently md, soon undo and slru so 12 in total. Any future smgr addition will expand this further. -- Shawn Debnath Amazon Web Services (AWS)