Date: Sat, 2 Mar 2019 09:40:22 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Joe Conway <mail@joeconway.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Tighten error control for OpenTransientFile/CloseTransientFile
Message-ID: <20190302004022.GA1602@paquier.xyz>
References: <20190301023338.GD1348@paquier.xyz>
 <09ffc3a3-0e1d-91c6-7748-890b1829469a@joeconway.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="/9DWx/yDrRhgMJTb"
Content-Disposition: inline
In-Reply-To: <09ffc3a3-0e1d-91c6-7748-890b1829469a@joeconway.com>
Precedence: bulk


--/9DWx/yDrRhgMJTb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Mar 01, 2019 at 05:05:54PM -0500, Joe Conway wrote:
> Seems like it would be better to modify the arguments to
> CloseTransientFile() to include the filename being closed, errorlevel,
> and fail_on_error or something similar. Then all the repeated ereport
> stanzas could be eliminated.

Sure.  Now some code paths close file descriptors without having at
hand the file name, which would mean that we'd need to pass NULL as
argument in this case.  That's not really elegant in my opinion.  And
having a consistent mapping with the system's close() is not really
bad to me either..
--
Michael

--/9DWx/yDrRhgMJTb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlx50PYACgkQnvQgOdby
QH10Pg//VzYmqAFa6G9cxj/h9SMigi0hVFfZa4G5P/zvCD4gIckTIqbn+TrDOdzl
fYmHJ4VbtpBPCqmWNCKDk2XTOlrB5ViRW/yBiIBY9A9hCWOokJfTvcmfWlkQTdzc
4FjmseAnBM6AWydZKAI+cJid+dBX7ZjYUxgT+YE6L+oh2opRz49kPE+nhk2dXFKk
qiJNh5C7UEpCUTgIbNWm+UEywuaxiWBfWllkIWopr7V8Yex6pxzB16lmy1iD36+y
E5lt6SaMy/maXSnmT7EfQXRaiM6YF5kkvN14fMLfBj+yHKXrZVNz01L3nooWKJ5X
LFkgjmGIcrQZJqMCzbE2f0X7RvW+vbc3aIN4uZPhC1arZ01b+lBv4W7Qc5TMIxdy
H3x+mjkGWvx7txAxZVQ2SAauzDtzvV+FLryvMHZcst5kHHxbfukZ7Gbk/PlaIT9M
eLhaSX9vAQzk5FkdjDseoCphDKnsSGwmlnRzM3uVVVJa4OWhxE7mcNIO5bXe/2xq
Jq4BSlSz1XeV1kouBnZViewY9fwu01+zxZV2ZPjTiJTTq4Gd5hwt+eISjwBNjcHS
baT9I4zln48PK1GjbCOjHfPS5aBq/zb8t6Ntr/9YGXlwLkx4VfSG8whv4A7k5by1
8jajn9jw9gCn7lXjftP6gq6YPFSJc5rNZaKTGqKl/9CLqt+wEuI=
=DFGn
-----END PGP SIGNATURE-----

--/9DWx/yDrRhgMJTb--