Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1h0sl0-0004dq-Mu
	for pgsql-hackers@arkaria.postgresql.org; Mon, 04 Mar 2019 18:56:10 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1h0skz-0004m7-Eh
	for pgsql-hackers@arkaria.postgresql.org; Mon, 04 Mar 2019 18:56:09 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1h0skz-0004gC-3k
	for pgsql-hackers@lists.postgresql.org; Mon, 04 Mar 2019 18:56:09 +0000
Received: from mail-qk1-x743.google.com ([2607:f8b0:4864:20::743])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1h0skv-0003S7-Sn
	for pgsql-hackers@postgresql.org; Mon, 04 Mar 2019 18:56:07 +0000
Received: by mail-qk1-x743.google.com with SMTP id f196so3374490qke.10
        for <pgsql-hackers@postgresql.org>;
 Mon, 04 Mar 2019 10:56:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition
         :content-transfer-encoding:in-reply-to:user-agent;
        bh=VZTTEVtcWA9A01Fam8oN7jFM5kQXYhhrODaHHNrm/Vg=;
        b=aQ8RA5jJaxwCwphKFtHFMGk5v4BGtCupFoRkirNx4ka68rhFhSEMQVZvgBciTJYt2u
         pOCaqz8ODB1/CTskKvt5WfGVr2fiBJgM3vhrq22thoj9tmndlbudJeio9l0g4/QTCN4A
         QKrK/LH2CVdTSnjf3eb5vw0uK2G8u8o6oiM+LT/GUDgNceCwuLOZHwCq66FYARFCLpXO
         ptUuDnbA1dxyHkB4loAgjYiQGcJvwFmGnaoQM5qaJrTFVxSrA5Mv0SVRPnB+SFloaS3x
         6C2wcFxWGEO6q/gRgWEbnI+PQFm59q/1MJW9PjP5mgDd53pwLGV1TcqVZUkMTnI8qO6O
         0GxA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition:content-transfer-encoding:in-reply-to
         :user-agent;
        bh=VZTTEVtcWA9A01Fam8oN7jFM5kQXYhhrODaHHNrm/Vg=;
        b=PLtSnUyqHAzXXSj0/moKXdb99Z+v1mvWIgeAtE506TrAYXOiY4peULYvvWafh4HAWR
         4ZjRdoatKJ5z/g8ljrOcnFoodxU//tEhf9e8Io6vrWSGCzwzpAMTU8bVDIJ4V8aui97K
         BsjSM7SJIFM4kvRGTTP8fINtqfmXzz5moopE/gr3Hgg/27wiJLPInl28CPjGL49N/20G
         nhXPHw7xrqZOcH6HXQDKIgsPv96ttNrhao5vZyVbiGCXkdF1j2bIMRKv6wTUfVMVGxvE
         iI3yDLWP1hB2Cx7EvvIrkAuoYYa4CkWpCtwAhAO3AK+kQWMsDFKSdxLO8hvbzunpv2lY
         eqeg==
X-Gm-Message-State: APjAAAUnSDGjuIROXkf4rC7P/VcM/pX/waxMV1zxCNUYW7RlEfA3mVWG
	t7hZ/D0zXkVI7ZzupupMuGY3Hw==
X-Google-Smtp-Source: 
 APXvYqzKwiKQiq+sg6P+ffvgBoXmgrLxcpvSbI0VBmBTTf+ZGH97rhx0NX0HQy9DYpb00GzYmT6/NQ==
X-Received: by 2002:a37:58a:: with SMTP id 132mr14938744qkf.335.1551725764856;
        Mon, 04 Mar 2019 10:56:04 -0800 (PST)
Received: from nimloth.alvh.no-ip.org ([191.126.227.90])
        by smtp.gmail.com with ESMTPSA id
 o26sm3919935qtm.65.2019.03.04.10.56.04
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Mon, 04 Mar 2019 10:56:04 -0800 (PST)
Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000)
	id 2380812193E; Mon,  4 Mar 2019 15:56:00 -0300 (-03)
Date: Mon, 4 Mar 2019 15:56:00 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Stephen Frost <sfrost@snowman.net>,
	Postgres hackers <pgsql-hackers@postgresql.org>,
	Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Subject: Re: pg_partition_tree crashes for a non-defined relation
Message-ID: <20190304185600.GA24510@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190228193203.GA26151@alvherre.pgsql>
User-Agent: Mutt/1.9.4 (2018-02-28)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

On 2019-Feb-28, Alvaro Herrera wrote:

> What about legacy inheritance?  I see that pg_partition_tree handles
> that case perfectly well -- it seems to return the complete hierarchy
> rooted at the given relation.  However, it seems odd that it works at
> all, don't you think?  Consider this:
> [...]
> I would opt for returning the empty set for legacy inheritance too.

I added tests to immortalize the current behavior for legacy inheritance
relations too.  Thanks!

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services