Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h1Dfj-0001PX-Ix for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Mar 2019 17:16:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h1Dfi-0004UC-Bu for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Mar 2019 17:16:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h1Dfi-0004Rd-42 for pgsql-hackers@lists.postgresql.org; Tue, 05 Mar 2019 17:16:06 +0000 Received: from smtp-fw-2101.amazon.com ([72.21.196.25]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h1Dff-0006oT-Iv for pgsql-hackers@postgresql.org; Tue, 05 Mar 2019 17:16:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1551806163; x=1583342163; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=zgbD0UmL8Wdsy64vAfatiJk8BtyqM9Vnw47jW7gvQXM=; b=PEW8r/CDiBWcI0I7eKwPGh2QwdayioRtfPlSiPK2AiqUqhZoisyAFP7Z GN6WC6fYJgI44HT+fBEFFdyOlyNBI46W/h++Q2h/UsIlV9TLnz56KUkil x5WFMUvy0V6g5rkNGOEcFOu72UGarniFxRrVi1bo8A5UCHvgINA+a/guA U=; X-IronPort-AV: E=Sophos;i="5.58,444,1544486400"; d="scan'208";a="720674472" Received: from iad6-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-2a-6e2fc477.us-west-2.amazon.com) ([10.124.125.2]) by smtp-border-fw-out-2101.iad2.amazon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 05 Mar 2019 17:16:00 +0000 Received: from EX13MTAUWC001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198]) by email-inbound-relay-2a-6e2fc477.us-west-2.amazon.com (8.14.7/8.14.7) with ESMTP id x25HFwAL034310 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 5 Mar 2019 17:15:59 GMT Received: from EX13D05UWC002.ant.amazon.com (10.43.162.92) by EX13MTAUWC001.ant.amazon.com (10.43.162.135) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 5 Mar 2019 17:15:58 +0000 Received: from f01898859afd.ant.amazon.com (10.43.160.25) by EX13D05UWC002.ant.amazon.com (10.43.162.92) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 5 Mar 2019 17:15:58 +0000 Date: Tue, 5 Mar 2019 09:15:57 -0800 From: Shawn Debnath To: Tom Lane CC: Thomas Munro , Andres Freund , Dmitry Dolgov <9erthalion6@gmail.com>, Robert Haas , PostgreSQL-development Subject: Re: Refactoring the checkpointer's fsync request queue Message-ID: <20190305171557.GA30015@f01898859afd.ant.amazon.com> References: <20190222234549.GA7397@f01898859afd.ant.amazon.com> <20190222235742.4oed46wocpjfpoa5@alap3.anarazel.de> <20190227212653.GA7171@f01898859afd.ant.amazon.com> <2a1667c64cc0485bb781704876ac5a0a@EX13D05UWC002.ant.amazon.com> <20190305160715.GA26468@f01898859afd.ant.amazon.com> <3127.1551804796@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <3127.1551804796@sss.pgh.pa.us> User-Agent: Mutt/1.11.3 (2019-02-01) X-Originating-IP: [10.43.160.25] X-ClientProxiedBy: EX13D03UWA004.ant.amazon.com (10.43.160.250) To EX13D05UWC002.ant.amazon.com (10.43.162.92) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Tue, Mar 05, 2019 at 11:53:16AM -0500, Tom Lane wrote: > Thomas Munro writes: > > +#include "fmgr.h" > > +#include "storage/block.h" > > +#include "storage/relfilenode.h" > > +#include "storage/smgr.h" > > +#include "storage/sync.h" > > > Why do we need to include fmgr.h in md.h? > > More generally, any massive increase in an include file's inclusions > is probably a sign that you need to refactor. Cross-header inclusions > are best avoided altogether if you can --- obviously that's not always > possible, but we should minimize them. We've had some very unfortunate > problems in the past from indiscriminate #includes in headers. Agree - I do pay attention to these, but this one slipped through the cracks (copied smgr.h then edited to remove smgr bits). Thanks for catching this, will fix in the next patch iteration. -- Shawn Debnath Amazon Web Services (AWS)