Date: Wed, 6 Mar 2019 16:19:00 +0900
From: Michael Paquier <michael@paquier.xyz>
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	Andres Freund <andres@anarazel.de>
Subject: Re: pg_dump is broken for partition tablespaces
Message-ID: <20190306071900.GI30982@paquier.xyz>
References: 
 <CAKJS1f_1c260nOt_vBJ067AZ3JXptXVRohDVMLEBmudX1YEx-A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="rmUrFcWP4LYae1gV"
Content-Disposition: inline
In-Reply-To: 
 <CAKJS1f_1c260nOt_vBJ067AZ3JXptXVRohDVMLEBmudX1YEx-A@mail.gmail.com>
Precedence: bulk


--rmUrFcWP4LYae1gV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 06, 2019 at 07:45:06PM +1300, David Rowley wrote:
> Partitioned indexes have this similar inherit tablespace from parent
> feature, so ca4103025dfe26 was intended to align the behaviour of the
> two. Partitioned indexes happen not to suffer from the same issue as
> the indexes are attached after their creation similar to what I
> propose above.
>=20
> Can anyone see any fundamental reason that we should not create a
> partitioned table by doing CREATE TABLE followed by ATTACH PARTITION?
>  If not, I'll write a patch that fixes it that way.

The part for partitioned indexes is already battle-proven, so if the
part for partitioned tables can be consolidated the same way that
would be really nice.

> As far as I can see, the biggest fundamental difference with doing
> things this way will be that the column order of partitions will be
> preserved, where before it would inherit the order of the partitioned
> table.  I'm a little unsure if doing this column reordering was an
> intended side-effect or not.

I don't see any direct issues with that to be honest thinking about
it..
--
Michael

--rmUrFcWP4LYae1gV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlx/dGQACgkQnvQgOdby
QH3QLw//Xq4pOcQy2K6a0kLk6fFh6cF1jIh0lj3PTgCbYBXv+/42x428Fh8hek8N
qjKqoOEcu6Yul9Vj62//4wCR/RzSqUEzPhgXf6W1xw9/HfuXfdur/7TLKs9Hcd+F
0u9xzi7VAjpCkBC5HFdZx0uB9hsFRJDUqEDFZlg5bqWLYKNQrFq3Pr3PvcXc2TvG
Fxg4Tkf+Z9FlNB1xLbciD7+kGQYC8RRZKSFYC0G2sqqMDqhESrHVndAxLh43JHcd
o18eRF5ox/trdY/hRR7ZDwp3g4+tL6HgVl6LWoS474s2DQebJMyU6+QOAh5Z+RUi
ebROQgD+k4pXC0zgqU4b3MnD5oj3TeuFYLxX6wRMjXuFZ0x1yuN1R0junDZokc2y
FZ0OoDP1fUE++IUzrcGbMsIvgXCfp1F0xQsqrn72Jzkl6tWzjJdzsbo/Vo6cWM9j
Eq4hV2dDSxazgg6ShNlx2iNrROImwLKNRDFwjWEvmGAarH3xx2Gr1g2v1YqjGap4
Ism/dF7W/0sGRzHNjx0pAi3Uunf0KnLBvSzfwTXzU1AuOnOowrtdTCW/6kU18kMx
rUCQp2xwQyL7kWT4Tx2TDvBYlg9LFXB6hngvjIv0Zedb3ACaLMTjY4bTlYPgp1hu
0Z9q0h6fRSIcDq1eo2RemKlJCwK0RHMi3b8WtjElvVKACOeDSmw=
=XOH2
-----END PGP SIGNATURE-----

--rmUrFcWP4LYae1gV--