Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h1gLU-0006c7-9I for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Mar 2019 23:53:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h1gLS-0005ow-Ht for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Mar 2019 23:53:06 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h1gLR-0005op-Hx for pgsql-hackers@lists.postgresql.org; Wed, 06 Mar 2019 23:53:06 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h1gLO-0000MV-6O for pgsql-hackers@lists.postgresql.org; Wed, 06 Mar 2019 23:53:04 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 2836B21448; Wed, 6 Mar 2019 18:53:01 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 06 Mar 2019 18:53:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=UJ2gvzRdqD5VZY0pAl/cj07W8Qn z630h8KehxDE2zNQ=; b=PY5z8C17VSiLwGjd47yv+HkzfJ8XCMgX7Z2iXNBKznu JBDf6Ub4+BpUnvqscM46cFoV2mudgFM0Ec/pFW3GTdqCniVg2et3HCuNh6MEE+eF +CSfoROlmXxTw4AQ87kFqn07hHsP7sFparsCNRB+gv1QjBMZQp0Aw/kLAlyPADV+ vY7tytks3NveMW/5ra3BeedSsAeATDufmxpSflgvTVpNjd89Awp7KRO4jotFsMTx DknICXR98EF9CUeWSYepiGKGv5T7QBBAp+De+YTpfgpd9676BY6WQirrbph3W0rI ps4uRlrzkgAM610e08rrH5PQ1qdS5v3NerWe4IfnSLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=UJ2gvz RdqD5VZY0pAl/cj07W8Qnz630h8KehxDE2zNQ=; b=5BtaI4PGP+V4Da15pG1Qew MDoiGObM2w8A7EqCrwGP0zOMKMz3ydz7KToH3K3uKQfy1Tbm2Ffx34SdYrrj7frq QcP2o6kW0lHH7rfsoJUjYE8S4TSo0u8R75TyWMvVuzdFT2kk8Wg3e8WiwTPyKtUQ TcJ7U4nKdThkWgqfUhbT1Qv3glfWABfhuZhuLHTjWZnPYSqXt0jN4slstaOw9E4w dGWGnv7/toe35kgrbrPv9pHnXJIp9PACizL7SWmqrlrd1B7zOY0LnnRHPxRWy/5Y IItL4rPefpNs1z3vkf+vlQ03xgzAoUoxTJ2oyPXnn5Kc06NUzNUxyeGR1ZOlgjKw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrfeejgddugecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdefhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuffhomhgrihhnpehpohhsthhgrhgvshhqlhdrohhrghenucfk phepiedurddvudehrddufeejrdduiedvnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmih gthhgrvghlsehprghquhhivghrrdighiiinecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id 1F072E4580; Wed, 6 Mar 2019 18:52:58 -0500 (EST) Date: Thu, 7 Mar 2019 08:52:51 +0900 From: Michael Paquier To: Robert Haas Cc: Postgres hackers Subject: Re: pgsql: Removed unused variable, openLogOff. Message-ID: <20190306235251.GA17293@paquier.xyz> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZGiS0Q5IWpPtfppv" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --ZGiS0Q5IWpPtfppv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Mar 06, 2019 at 02:47:16PM +0000, Robert Haas wrote: > Removed unused variable, openLogOff. Is that right for the report if data is written in chunks? The same patch has been proposed a couple of weeks ago, and I commented about it as follows: https://www.postgresql.org/message-id/20190129043439.GB3121@paquier.xyz -- Michael --ZGiS0Q5IWpPtfppv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlyAXVMACgkQnvQgOdby QH09rw/+N6hk4gahepyH1IugQn78/2SxCkrEQZZ19Waxe1bbjBNTWAkGLKgYmz+C 7VzV5QiUiO7giOqhM2bYgln5S837YbDuFC23vJEzsPQ6GeJ42tvmWAtU4gZystsH GzYRsSmwPLU7VOszVKQ8O3I8uNW/2szBsz/rurygSATFcXL0BzLM2EoRXgXZn+DO 3akWlKRfSsSV3bsvyCtRXuR2SAwxm9td9rW74zlXMG4ICDBVob53W4B43BF1hLWe yHOX4a6r/ACAEbNvE26iOPtMAJHM1o2d8L7Nso/UDSbLYavW1rXgFzyzcHRWCw96 EezJwACYZrF6t5Ul6jTKyaZ2BhcFuBUTNmdjUlxuvkQBAmYFWuFzDvc01ybSt6p1 K+P0tvLbAT2U+1q3QgEwl5SvUqCpCazAko7orVAFcozvtSz6VTcmYGZCCMTsrs8n NKOQLGUi/XowkdvpA4Dx9v89wBSDZ1caKZmCV7g1Z7jP3+sONtj9qe4A6wQqJJK7 bU70DA1MqZRPt7jN5h5bidOCGeTaYN6sEX39Kc64NeLOs+Xk8VrcObU7UbU1FRYS 2APlnQ1MvRy8jeaooZ58KFBO4CZSguqTn6kIJ2r361gHwDzEHm84HV2M49RA46m0 oMgWStzfPMScNSnl3Jkt7zcntx47Mfi3j0TQmd0rWGpxyIEnm+Q= =2arC -----END PGP SIGNATURE----- --ZGiS0Q5IWpPtfppv--