Date: Fri, 8 Mar 2019 16:11:25 +0100
From: David Fetter <david@fetter.org>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Magnus Hagander <magnus@hagander.net>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: psql show URL with help
Message-ID: <20190308151125.GL10435@fetter.org>
References: <47e071fd-8997-f036-b383-4d80c184adeb@2ndquadrant.com>
 <a8df897e-f1df-b539-a85d-298c678d4180@2ndquadrant.com>
 <20190303181432.GA316@fetter.org>
 <CABUevEyc98E-Jxq-S5jEttiwrdxkAZbpUNsoEt5=DwgVqauY5g@mail.gmail.com>
 <20190303214833.GD10435@fetter.org>
 <CABUevEwUrZWa+8S3_mZ+6HrxUPvFjVU8Os6AKZiKa2KTGnwhQw@mail.gmail.com>
 <b8f27893-a7fb-1dd6-efe8-ca2f228b8578@2ndquadrant.com>
 <CABUevEwNHUe3mHO5QXG9J14ag=7ubbfp6-QxxAOkt+jmfg6rTg@mail.gmail.com>
 <20190307220234.GI10435@fetter.org>
 <aa2e4abb-00a9-76b8-fe96-594e9768f699@2ndquadrant.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <aa2e4abb-00a9-76b8-fe96-594e9768f699@2ndquadrant.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Fri, Mar 08, 2019 at 01:45:03PM +0100, Peter Eisentraut wrote:
> On 2019-03-07 23:02, David Fetter wrote:
> >> if (psql_version_is_numeric)
> >>  return /docs/psql_version/
> >> else if (psql_version ends with 'devel')
> >>   return /docs/devel/
> >> else
> >>   return /docs/{psql_version but with text stripped}/
> >>
> >> So that e.g. 12beta would return "12", as would 12rc or 12alpha. But
> >> 12devel would return "devel".
> > 
> > That's exactly what I had in mind :)
> 
> The outcome of that is exactly what my patch does, but the inputs are
> different.  We have PG_MAJORVERSION, which is always a single integer,
> and PG_VERSION, which could be 10.9.8 or 11beta5 or 12devel.  The patch does
> 
> if (PG_VERSION ends with 'devel')
>   return /docs/devel/
> else
>  return /docs/$PG_MAJORVERSION/
> 
> There is no third case.  Your third case of not-numeric-and-not-devel is
> correctly covered by the else branch.

Thanks for helping me understand.

Best,
David.
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate