Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h34lN-0006pv-R1 for pgsql-hackers@arkaria.postgresql.org; Sun, 10 Mar 2019 20:09:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h34lL-000463-V8 for pgsql-hackers@arkaria.postgresql.org; Sun, 10 Mar 2019 20:09:35 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h34lL-00045w-H9 for pgsql-hackers@lists.postgresql.org; Sun, 10 Mar 2019 20:09:35 +0000 Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h34lE-0002DT-5o for pgsql-hackers@lists.postgresql.org; Sun, 10 Mar 2019 20:09:34 +0000 Received: by mail-qt1-x842.google.com with SMTP id z17so2872476qtn.4 for ; Sun, 10 Mar 2019 13:09:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=jLmNFRuvGCNhSCghHOn18r56nproNIa3w00iK2BZUSo=; b=adG1pYL4VaFDH3/D8LohRYCh+ocZ4LlaW694BXyKOE25mRVbBUQonQ5i2iD5NbBVMS 3GZbaNXoo2YffzC+JKLI9iFv++dUz6DOci62LABU8mHVm0kE6nRaKiUadUrkLJSaxBP/ 9LxLtsQOy/0pQodZcIFd4v/Jeyx3rE0EYg92FeHvQh+eS/5z7st1l8HtbfYgq3UETZLf lm2LgZPIBbrDa9V3CFtHIrAx0bCKgBC3xfGazK4CWTAmCQFU3ZC7WgZ5q4fbYQKIubHR xhOU2jwWt5t+67RMsr9M11XqGLdpDFBiWHrnOMHiMsCcPeFh4aK6LBzZjO8Nut9i+QGc vX6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=jLmNFRuvGCNhSCghHOn18r56nproNIa3w00iK2BZUSo=; b=mmrg59t9Dx3AC8hUJ25dmiLtGnOIwjIy9E4KV+dGW+4MKblwuYLr1lVjsBPAJesk0u Lw94/ArVSlEkAtL1a0cdVGnMvCnx+LqYy6uAaME4DeH6o8CpAIsuxymp9lKTLtsaHDQy m7u2lm7hjUL0D80PdUa+bhwBpaaKQpR8rhE9xfbL/BYa2BxJL2nOdEo8c6kvU8f+vZ4T dpAQRCCUBfGPxm9sVAp+r1j1HiHsBH8f+kSakPvVFvHo61Wj8EVGD+psIETNpCaup9X4 WyJnPeoI1igGnE0GulBgCLuiquqsszAEZ6WK6zPikvEYmGbfEu8WqqzahgYo8RfAljLs vifQ== X-Gm-Message-State: APjAAAUwQhO38bqNBPTS7h2Q5o0CSfvHuM0e01/bULm0d+rx6xjUMvJk UMOKTfF9wFnNTBYUOkPaPuQ7s3ud6hhVMw== X-Google-Smtp-Source: APXvYqzyRWU0RpYeJh27vwFv5ZDnpY2glJPNZm8ZK3Yn833PCo8bBN8ydBm1OBpC8ymJagW2Ax+Ecw== X-Received: by 2002:ac8:54a:: with SMTP id c10mr3045374qth.43.1552248567147; Sun, 10 Mar 2019 13:09:27 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([201.186.80.67]) by smtp.gmail.com with ESMTPSA id a6sm2012237qkk.5.2019.03.10.13.09.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 10 Mar 2019 13:09:26 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id 63BE8121AAC; Sun, 10 Mar 2019 17:09:23 -0300 (-03) Date: Sun, 10 Mar 2019 17:09:23 -0300 From: Alvaro Herrera To: Tomas Vondra Cc: Postgres hackers Subject: Re: performance issue in remove_from_unowned_list() Message-ID: <20190310200923.GA4108@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <80c27103-99e4-1d0c-642c-d9f3b94aaa0a@2ndquadrant.com> User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Feb-07, Tomas Vondra wrote: > Attached is a WIP patch removing the optimization from DropRelationFiles > and adding it to smgrDoPendingDeletes. This resolves the issue, at least > in the cases I've been able to reproduce. But maybe we should deal with > this issue earlier by ensuring the two lists are ordered the same way > from the very beginning, somehow. I noticed that this patch isn't in the commitfest. Are you planning to push it soon? -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services