Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1h7M7e-0004Q9-GJ
	for pgsql-hackers@arkaria.postgresql.org; Fri, 22 Mar 2019 15:30:18 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1h7M7d-0005ot-4p
	for pgsql-hackers@arkaria.postgresql.org; Fri, 22 Mar 2019 15:30:17 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <cb@df7cb.de>)
	id 1h7M7c-0005om-Pw
	for pgsql-hackers@lists.postgresql.org; Fri, 22 Mar 2019 15:30:16 +0000
Received: from feynman.df7cb.de ([195.49.152.168])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <cb@df7cb.de>)
	id 1h7M7a-00008H-3Z
	for pgsql-hackers@lists.postgresql.org; Fri, 22 Mar 2019 15:30:15 +0000
Received: from msg.df7cb.de (unknown
 [IPv6:2003:5b:203b:100:7627:eaff:fe52:8e03])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client did not present a certificate)
	by feynman.df7cb.de (Postfix) with ESMTPSA id 44QnfD5X9nz3F0Q;
	Fri, 22 Mar 2019 16:30:12 +0100 (CET)
Date: Fri, 22 Mar 2019 16:30:12 +0100
From: Christoph Berg <myon@debian.org>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Michael Paquier <michael@paquier.xyz>,
	Andres Freund <andres@anarazel.de>,
	Michael Banck <michael.banck@credativ.de>,
	Magnus Hagander <magnus@hagander.net>,
	Sergei Kornilov <sk@zsrv.org>,
	PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Offline enabling/disabling of data checksums
Message-ID: <20190322153012.GE32388@msg.df7cb.de>
References: <20190319164717.ex2pw66zusbdqg2o@alap3.anarazel.de>
 <20190319230907.GA3488@paquier.xyz>
 <20190320051750.GA26601@paquier.xyz>
 <alpine.DEB.2.21.1903201012040.24709@lancre>
 <20190320125451.GA20192@paquier.xyz>
 <alpine.DEB.2.21.1903201712370.24709@lancre>
 <20190320225924.GC20192@paquier.xyz>
 <alpine.DEB.2.21.1903210745310.3843@lancre>
 <20190322002727.GJ20192@paquier.xyz>
 <alpine.DEB.2.21.1903221514390.2198@lancre>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.21.1903221514390.2198@lancre>
User-Agent: Mutt/1.10.1 (2018-07-13)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Re: Fabien COELHO 2019-03-22 <alpine.DEB.2.21.1903221514390.2198@lancre>
> Attached is a quick patch about "pg_rewind", so that the control file is
> updated after everything else is committed to disk.

>  	update_controlfile(datadir_target, progname, &ControlFile_new, do_sync);
>  
> -	pg_log(PG_PROGRESS, "syncing target data directory\n");
> -	syncTargetDirectory();

Doesn't the control file still need syncing?

Christoph