Date: Sat, 30 Mar 2019 04:24:16 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>,
	Michael Paquier <michael@paquier.xyz>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	Sergei Kornilov <sk@zsrv.org>,
	Jaime Casanova <jaime.casanova@2ndquadrant.com>
Subject: Re: [HACKERS] generated columns
Message-ID: <20190330092416.GO5815@telsasoft.com>
References: <57c70b3e-b29a-ad08-cdce-746f6d561e3d@2ndquadrant.com>
 <20190226053059.GF27822@paquier.xyz>
 <a9dcee31-6ae9-f581-f362-a27774cbe156@2ndquadrant.com>
 <20190227073124.GH3540@paquier.xyz>
 <4ebd3319-43df-94b1-4f5c-4149d8bd0031@2ndquadrant.com>
 <CAFj8pRApJQfre4zpAx+PR0KHazqzgJDEB=hG9hmdzt16xoaprw@mail.gmail.com>
 <20190320025103.GG3488@paquier.xyz>
 <d75e0126-8484-3dd9-0193-aa091299b130@2ndquadrant.com>
 <CAFj8pRD3L9pZqrh-2BuBaBHa2A-h3-xAoO0v2dujwaKtfeS1OQ@mail.gmail.com>
 <24577a1a-0216-3094-2360-1ddb2fc6a100@2ndquadrant.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <24577a1a-0216-3094-2360-1ddb2fc6a100@2ndquadrant.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk

On Sat, Mar 30, 2019 at 09:03:03AM +0100, Peter Eisentraut wrote:
> On 2019-03-26 20:50, Pavel Stehule wrote:
> > It is great feature and I'll mark this feature as ready for commit
> 
> Committed, thanks.

create_table.sgml now has this:

https://www.postgresql.org/docs/devel/sql-createtable.html#id-1.9.3.85.6.2.18.1.2
+     <para>
+      The keyword <literal>STORED</literal> is required to signify that the
+      column will be computed on write and will be stored on disk.  default.
+     </para>

What does "default." mean ?

Also, this is working but not documented as valid:
postgres=# CREATE TABLE t (j int, i int GENERATED BY DEFAULT AS (j*j+1) STORED);

Justin