Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hAxEX-0000RD-KU for pgsql-hackers@arkaria.postgresql.org; Mon, 01 Apr 2019 13:44:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hAxEW-0001AQ-5U for pgsql-hackers@arkaria.postgresql.org; Mon, 01 Apr 2019 13:44:16 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hAxEV-00017C-Qv for pgsql-hackers@lists.postgresql.org; Mon, 01 Apr 2019 13:44:15 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hAxET-0005Ep-4d for pgsql-hackers@postgresql.org; Mon, 01 Apr 2019 13:44:15 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id AF13D22008; Mon, 1 Apr 2019 09:44:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 01 Apr 2019 09:44:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=orJqT7YVf4MxvB41/p3pW3ZjcdJ gmAry2FANETJ8JYs=; b=Lom8EiSTA1x1CAcFu3K6vjWboBYh6JzIqPBHzqnjv/1 2/v5jP5KqTGHktmbNBWOkEtCfi0kVep8aFWnaNV7JMEHaIuqPSzUTsNFN8XmpFm0 4X/2oxnjqt1V1qR+CpjbSdIrpOGAebnI0zrZLnBgm8byPaPymLPUZexoM/EjvKtH vYFjMukSEhpiE4OuR3dnPjephkWWAjmEpcI5c51Ow9AE5s1B5/UrTCGddP1zfa33 L5IyrWLvKhWgqOe7SvgsxAT4EasSPkZ7Lr9TVAwFu8qZAd3eijT+Qr5l7nydBBjl 1Dk6b64dv0GM33PbU/izs4TxRerGa9rwsO12eqeiKug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=orJqT7 YVf4MxvB41/p3pW3ZjcdJgmAry2FANETJ8JYs=; b=KmlU/2s1s+ejH4Kihmb6tX n06i3LQtNVGCQVi5RTPvgIj4MYBCEnduohMyOXNgifC4Wq7dz6/DOBNl+qqB+vPZ OK3UpZoARpTBO/Z9ickPa5iZCZoytqbiVbYVniz05Y8eneiBgSF9I/wXKNA+AqCe u19ahbz/3n7HT/mT5KYZi5DoRUfGXNZYzBTjXv4oQBr9v2enkJ0wPzLqLeOAlPQo VDtc1xfDnEp/WlDeW5zNgB1VsX22aNRlSe9peOdfOwb4CRAnxTlvPwxhVhhb3R0K 4ms2FwYrWd1BfvqpYvIW4OQXikgC7k+eN65pj/T0m4CuehfNC/SDwH2+mK1tEwHA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrleeggdeiiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdefhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddu necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuffhomhgrihhnpehpohhsthhgrhgvshhqlhdrohhrghenucfk phepudduuddruddtvddrudektddrudekheenucfrrghrrghmpehmrghilhhfrhhomhepmh hitghhrggvlhesphgrqhhuihgvrhdrgiihiienucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 1CD12E4441; Mon, 1 Apr 2019 09:44:07 -0400 (EDT) Date: Mon, 1 Apr 2019 22:44:05 +0900 From: Michael Paquier To: Peter Eisentraut Cc: Jeff Janes , Pavel Stehule , pgsql-hackers , Sergei Kornilov , Jaime Casanova Subject: Re: [HACKERS] generated columns Message-ID: <20190401134405.GG16093@paquier.xyz> References: <20190227073124.GH3540@paquier.xyz> <4ebd3319-43df-94b1-4f5c-4149d8bd0031@2ndquadrant.com> <20190320025103.GG3488@paquier.xyz> <24577a1a-0216-3094-2360-1ddb2fc6a100@2ndquadrant.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hcut4fGOf7Kh6EdG" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --hcut4fGOf7Kh6EdG Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 01, 2019 at 10:53:27AM +0200, Peter Eisentraut wrote: > On 2019-03-31 15:22, Jeff Janes wrote: >> I can't do a same-major-version pg_upgrade across this commit, as the >> new pg_dump is trying to dump a nonexistent=A0attgenerated column from t= he >> old database.=A0 Is that acceptable collateral damage?=A0 I thought we >> usually avoided that breakage within the dev branch, but I don't know >> how we do it. >=20 > We don't. Really? I thought on the contrary that it should work. This reminds me of commit 59a884e9, which has been discussed here: https://www.postgresql.org/message-id/20160212001846.GB29511@momjian.us -- Michael --hcut4fGOf7Kh6EdG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlyiFaUACgkQnvQgOdby QH1FiA/8DGoj3/hTUvbroDmV8J9Tc8LOZxZ2cpVJMbQ80EOOn529NlPm389GlGEo jflJtZgu0hou6jMGhSBWJQ2p2J0HDS6iVuwWHVod8Gnquk09IPBvA/YQf4LArxgm pwyD60aNYoLlNhcxGhdltuALeEps8MUJt9t/fzKTMywA4wBTm1ZHShVvyvfjjdkc i7X+m/wFB1MwEq984Rz8WoijyIurOhymYGR1V+Ycb3BPomE6edp5zXux1NhpF3Hd zvJPaPaqqvVssrKTnJt1KfMnRCGNls76fD8Jn8Gk/7R/rEVdrAhE7lSfzSFMUgm+ EOBYLUY3s80+prO/CtBZ+QaQsvg4s6KFUqyxBUobBz+NTL1APxUhsiryEdcOBnsV YUx4w9yF67uOAYzudv19o4POzkW6SAYUgD//uXLfc0xB5yGLQMUttgzfe9SqmhSv RhAgYOI1fwS3aQRHCxMKUC/8sToHQI3C3xX7Oo6OYmg5eeFXOeitUlNgMi7wzBfl MGiii2tgm7/GRu7PbBIoRakr6+I2NBDpc7Mp3TA3eyTW39uQGP2fZBAZFzx0UpLD 4083tHZqhZmUJ3zNXB05F3H0QtJ24DSvnR4Eef4LgaEPcxH4r0rbhQGpwq5iAL/U jhlu0euIGHH/SbQAeE2PoBU3iC4YsC1PamOyWaK/67sPVhLNnSE= =HC00 -----END PGP SIGNATURE----- --hcut4fGOf7Kh6EdG--