Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hB0On-0006sd-V8 for pgsql-hackers@arkaria.postgresql.org; Mon, 01 Apr 2019 17:07:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hB0Om-0006PJ-GU for pgsql-hackers@arkaria.postgresql.org; Mon, 01 Apr 2019 17:07:04 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hB0Ol-0006PB-CL for pgsql-hackers@lists.postgresql.org; Mon, 01 Apr 2019 17:07:04 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hB0Oj-0000Et-7V for pgsql-hackers@postgresql.org; Mon, 01 Apr 2019 17:07:02 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 676122202A; Mon, 1 Apr 2019 13:07:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 01 Apr 2019 13:07:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=YhZ+KfBeFVd7udmeFWRXbj85PVE k0YEG0HFDr50W+LQ=; b=hlOVrWMMQ8KEQHbsPVYik8z3p08ivpolCO1A8R45LZx M30DHne6nedWauGhtsUCZryqxuWEsX6sYymJKQFlHWUTpZbxJFbJ8cVtBXzxpfB/ LyynSRs8GcXbK2dq027mqnezhcuDmbxV0BtENh413gXrXjSqE4XExlXE9H0QLnBB RoFOYAdP3dxMIJDczTjB4Dx748rrWSoLTngAHoOPXuMf1kUSeTeDAHCRSaSLnnQr 6zn0CXRcqekh57yRIY/f5WrWus7qOD+T6CiIt652i/4rpfPR75e5H/Tv/bypUtYQ rljGB+hfpy++MPfOaKR3GpecZVNFqeccDhNP609LPSw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=YhZ+Kf BeFVd7udmeFWRXbj85PVEk0YEG0HFDr50W+LQ=; b=i131owg8AQRVGCSTSpXoDm rpyFnHyCT35LB9EwXTo7blpMIa8hzPpdH1aq2ypvvUG3GZFe/IsmYKPhRrptcxhV 6Ffue++ip6954ItYoSMwt8EJdGz8yDfy4U958OeR8u/PpO/BS374BDxz27jP3KYa K+W/BCVdkKUo5MTQQ+y0f7nN0MuOJZhZJYJmRGaMA9/q8YIj6hCUdV/+jo5TkA44 gnomMl0iJyxS0/0e03P1ZVRuVmA6beT/pLY/8yEU5Yctglj/9ot4HsLG6eGawexW teImaYXPmkjcozGp6/bridnNKxPERrL1STK9v9OeH2T56IVlDFkYoPLr7/rIgP2w == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrleeggddutdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgurhgv shcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucfkpheple ekrddvuddtrddugedtrddujedunecurfgrrhgrmhepmhgrihhlfhhrohhmpegrnhgurhgv shesrghnrghrrgiivghlrdguvgenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from intern.anarazel.de (c-98-210-140-171.hsd1.ca.comcast.net [98.210.140.171]) by mail.messagingengine.com (Postfix) with ESMTPA id 821121031A; Mon, 1 Apr 2019 13:06:59 -0400 (EDT) Date: Mon, 1 Apr 2019 10:06:58 -0700 From: Andres Freund To: Noah Misch Cc: pgsql-hackers@postgresql.org Subject: Re: Extending USE_MODULE_DB to more test suite types Message-ID: <20190401170658.ugoa7babvrxw2paa@alap3.anarazel.de> References: <20190401135213.GE891537@rfd.leadboat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190401135213.GE891537@rfd.leadboat.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-04-01 06:52:13 -0700, Noah Misch wrote: > I plan to back-patch the PostgreSQL patch, to combat buildfarm noise. Perhaps > someone has test automation that sets USE_MODULE_DB and nonetheless probes the > exact database name "pl_regression", but I'm not too worried. The original > rationale for USE_MODULE_DB, in commit ad69bd0, was to facilitate pg_upgrade > testing. Folks using "make installcheck-world" to populate a cluster for > pg_upgrade testing will see additional test coverage, which may cause > additional failures. I'm fine with that, too. +1 for all of that. Greetings, Andres Freund