Date: Mon, 1 Apr 2019 16:18:10 -0700
From: Andres Freund <andres@anarazel.de>
To: Haribabu Kommi <kommi.haribabu@gmail.com>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	David Rowley <david.rowley@2ndquadrant.com>,
	Robert Haas <robertmhaas@gmail.com>, Asim R P <apraveen@pivotal.io>,
	Pg Hackers <pgsql-hackers@postgresql.org>,
	Ashwin Agrawal <aagrawal@pivotal.io>,
	Dmitry Dolgov <9erthalion6@gmail.com>,
	Alexander Korotkov <a.korotkov@postgrespro.ru>,
	Heikki Linnakangas <hlinnaka@iki.fi>
Subject: Re: Pluggable Storage - Andres's take
Message-ID: <20190401231810.arpvmhw66bwsyobj@alap3.anarazel.de>
References: 
 <CAJrrPGd+rkz54wE-oXRojg4XwC3bcF6bjjRziD+XhFup9Q3n2w@mail.gmail.com>
 <20190309031825.zlgqs3tg424g3lkf@alap3.anarazel.de>
 <CAJrrPGcwaAtaRF9dOfSi0unTLU9WyD+Z9jQ8h0exE0kHu9V1dw@mail.gmail.com>
 <20190312.172757.17614556.horiguchi.kyotaro@lab.ntt.co.jp>
 <CAJrrPGeUqNy0BxWuDd1n5cLQoWUwQ5jhKnDQ6Ty3wt=KsyOoPQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAJrrPGeUqNy0BxWuDd1n5cLQoWUwQ5jhKnDQ6Ty3wt=KsyOoPQ@mail.gmail.com>
Precedence: bulk

Hi,

On 2019-03-16 23:21:31 +1100, Haribabu Kommi wrote:
> updated patches are attached.

Now that nearly all of the tableam patches are committed (with the
exception of the copy.c changes which are for bad reasons discussed at
[1]) I'm looking at the docs changes.

What made you rename indexam.sgml to am.sgml, instead of creating a
separate tableam.sgml?  Seems easier to just have a separate file?

I'm currently not planning to include the function-by-function API
reference you've in your patchset, as I think it's more reasonable to
centralize all of it in tableam.h. I think I've included most of the
information there - could you check whether you agree?

[1] https://postgr.es/m/CAKJS1f98Fa%2BQRTGKwqbtz0M%3DCy1EHYR8Q-W08cpA78tOy4euKQ%40mail.gmail.com

Greetings,

Andres Freund