Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hBPWU-0005UG-Bs for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Apr 2019 19:56:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hBPWS-0006mS-LZ for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Apr 2019 19:56:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hBPWS-0006mK-9e for pgsql-hackers@lists.postgresql.org; Tue, 02 Apr 2019 19:56:40 +0000 Received: from mail-qt1-x844.google.com ([2607:f8b0:4864:20::844]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hBPWP-0003MI-Om for pgsql-hackers@postgresql.org; Tue, 02 Apr 2019 19:56:39 +0000 Received: by mail-qt1-x844.google.com with SMTP id v32so16508625qtc.10 for ; Tue, 02 Apr 2019 12:56:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=9Rsp27uZCb66FXttPUoWC4gzdCzb4M8Om6ijEoUiNLU=; b=V0n41Vqx6q47pajHm73vtbg47qFH5q/fKfgjLM1Z8MnNiGM5EUFyDAn3LG2mdr/k26 UKYCrnrJeRaOZsBMt/TQTqr/yao7smjup6GfIlejhOjegkoYVP0C2l/bERIgZZx1Fhwe Iis/mGpq8mDRHWEHqzuqLtX39MbrTyPiYwHI7u15/3TbfWXCsY16ssQVGS5tCmTJfCit uuxCeVjaAr3IlXg5vJCsa5DuHxEdGnvO760PCGtoVzGr6+lWxYEq+a9gxaImcDzP8Uwz o/KteolugA2Cl1u+TTdppVxk/EiuSSN9B9ffBq09yxKNzawIwUYL50wDQx7xGhFz2P42 /nDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=9Rsp27uZCb66FXttPUoWC4gzdCzb4M8Om6ijEoUiNLU=; b=am6T12WZFSFPgF/DBszzd//huqPaNsRbpvd32HxImQUuIoWt990ldvMuYakduspm1Z bKLtVXU/6OXhhGCUcu6or64qMoXuJuwnSX7+08UjDB0qYS1iN65MrCSvNP6Hkopgpozl Q5xc6vStZr1MDOkIZC7FZAIrLjo/LCnEnYkZXB5PXK/Dcd4rQ9Dv8pVDLKP8wOKTT0Yr 7B+u71cJY2OiRPTmNTzqiEhkGowI5zIeBWpswyFvBs0ro0eedvKR3bkHVTChz18UR3g3 p2AgsY+NjMTb63fwzmg/qI2J0tQyc7bomG7QaWHcoGIhFKHLKfzAe7r3Xi0mHUjBb2ut Szdw== X-Gm-Message-State: APjAAAVDeX7EYgJpR9YZf8lH8FSYi+kyCDciWB9Q0rCkLOKVPC6OdmOo 2zFe060f5VyPQdieo4pzlqoYsA== X-Google-Smtp-Source: APXvYqwef2k3bghgvfnUKPOLPAxt13NN0uBt/O80BbmcssjCcQkMaAXkoCX2gdYpbPsbIPJvkvH+ZQ== X-Received: by 2002:ac8:26f7:: with SMTP id 52mr59556449qtp.325.1554234996971; Tue, 02 Apr 2019 12:56:36 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([190.121.29.3]) by smtp.gmail.com with ESMTPSA id a188sm1011899qkf.34.2019.04.02.12.56.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Apr 2019 12:56:36 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id 957C9120D16; Tue, 2 Apr 2019 16:56:34 -0300 (-03) Date: Tue, 2 Apr 2019 16:56:34 -0300 From: Alvaro Herrera To: Peter Eisentraut Cc: pgsql-hackers , Donald Dong , Andres Freund , Tom Lane Subject: Re: Unified logging system for command-line programs Message-ID: <20190402195634.GA14682@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk I don't much like the code that does pg_log_error("%s", something); because then the string "%s" is marked for translation. Maybe we should consider a variant that takes a straight string literal instead of a sprintf-style fmt to avoid this problem. We'd do something like pg_log_error_v(something); which does not call _() within. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services