Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hC21K-0006QX-MB
	for pgsql-hackers@arkaria.postgresql.org; Thu, 04 Apr 2019 13:03:07 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hC21J-0007aw-5S
	for pgsql-hackers@arkaria.postgresql.org; Thu, 04 Apr 2019 13:03:05 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1hC21I-0007ap-Sw
	for pgsql-hackers@lists.postgresql.org; Thu, 04 Apr 2019 13:03:04 +0000
Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1hC21G-0001Ek-1D
	for pgsql-hackers@postgresql.org; Thu, 04 Apr 2019 13:03:04 +0000
Received: by mail-qt1-x842.google.com with SMTP id k14so3102944qtb.0
        for <pgsql-hackers@postgresql.org>;
 Thu, 04 Apr 2019 06:03:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition
         :content-transfer-encoding:in-reply-to:user-agent;
        bh=csL5KR5VFH38XaR0Iryd6Ed9SWZifzcvMrAWlr8pHho=;
        b=OMrMQO/Bm/ohBl6c9MXnZ7h+EAMfLQkF2VvjQM14hDsfxYopGp+eRPqZUpVL34Hfrm
         RYuDmL3abfAy5FjxlyeYJbEh5mvsV053K9twde17xvUZ71LFu9t+1K/H7F8E/Ezxkp4x
         /aCWFFquRStgrmcEHpWu5uwDRcQ7qmbXBsdm0ef/jB8VlvtwpZnERCQctraT2eJ3e287
         u7U9rAi5rbSDJaTRUwJOmQfXBIa6kqAMosQGwRzZYG0L1OBHXKw8uNUgx0lFrcmW0EiD
         eBJ8xaWJna2dCJtj3dlHgOWg+a/pp/JkpYIpBrLnu7uEcTGJqtjdWkkzRgAKRpA5fi9U
         2vsg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition:content-transfer-encoding:in-reply-to
         :user-agent;
        bh=csL5KR5VFH38XaR0Iryd6Ed9SWZifzcvMrAWlr8pHho=;
        b=hAqPtrHFcg173qY18JIaPDLs0eFLVUYxpsuAiSHLYQLVSOMc+XrkpgY+EmCFgZ47YT
         3vKcJhkhvEyVj3Es3Llzabxxg4SIkQdQLVdhY7VJDOUMVkoAYq2kDtBC+RSNsLKyIMcj
         Z7KJPWHBdLEYB9xH+y8qy1qK4+8N2rnpDIM2n2xfyafB8xwcAYJdz0WhHcbCDLT1cFn6
         Qs4bzsLENVSZ8BQe9vUbu69M5vruV/+jKYQSrmBB0kNPT7+GrlcaKM4i/zePgIJwWjd8
         KLrRVajSVKZ95bmYejuX9A/QbYVZkpz4Z/0WtNhS/V7F9EIxWjf+MbLtJmcrNo9rSUH4
         4wtQ==
X-Gm-Message-State: APjAAAUcUt/MGTymKEzGyn8p32jJFQirPcom+lHZFl5jWD8efu6HXadb
	3nmWyvK9SUDx7dFltVi+klPUOg==
X-Google-Smtp-Source: 
 APXvYqwdUItwraG1Dbc6Q4tFZkpWbaawGtKwifl2FQu/l6k9I2jb4DefBLnu3TkV+Fo1rqba+K7Iyw==
X-Received: by 2002:ac8:1a5a:: with SMTP id q26mr5083458qtk.283.1554382980665;
        Thu, 04 Apr 2019 06:03:00 -0700 (PDT)
Received: from nimloth.alvh.no-ip.org ([190.121.29.3])
        by smtp.gmail.com with ESMTPSA id
 x15sm9314328qkh.13.2019.04.04.06.03.00
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Thu, 04 Apr 2019 06:03:00 -0700 (PDT)
Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000)
	id 60E0012114A; Thu,  4 Apr 2019 10:02:58 -0300 (-03)
Date: Thu, 4 Apr 2019 10:02:58 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Shawn Debnath <sdn@amazon.com>, Andres Freund <andres@anarazel.de>,
	Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Dmitry Dolgov <9erthalion6@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Refactoring the checkpointer's fsync request queue
Message-ID: <20190404130258.GA7320@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CA+hUKGLRWQTZwUC0vdiPs=RYu8B+2g7VJFaV0iP6cUFbKheHug@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

On 2019-Apr-04, Thomas Munro wrote:

> I don't think it's project policy to put a single typedef into its own
> header like that, and I'm not sure where else to put it.

shrug.  Looks fine to me.  I suppose if we don't have it anywhere, it's
just because we haven't needed that particular trick yet.  Creating a
file with a lone typedef seems better than using uint32 to me.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services