Date: Thu, 4 Apr 2019 10:48:19 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	David Steele <david@pgmasters.net>, Joe Conway <mail@joeconway.com>,
	Magnus Hagander <magnus@hagander.net>,
	Michael Paquier <michael@paquier.xyz>,
	Nico Williams <nico@cryptonector.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Robbie Harwood <rharwood@redhat.com>
Subject: Re: [PATCH v20] GSSAPI encryption support
Message-ID: <20190404144818.GI6197@tamriel.snowman.net>
References: <5ec3f734-810e-36e0-030f-af92efe135da@2ndquadrant.com>
 <20190223162751.GO6197@tamriel.snowman.net>
 <1f799b02-d766-0328-45d6-73e5674d0bc2@2ndquadrant.com>
 <CAOuzzgprZ7-gYkzwkPzMOPka62irppKpXNm219q7a_8Fu33TLw@mail.gmail.com>
 <500b1be7-d0aa-96a2-9982-d748609faff5@joeconway.com>
 <CABUevEyuNNJv=19foa=ycTfTfBUYOEwM8_Uss5OVKrwBAy+Btw@mail.gmail.com>
 <20190403144332.GD6197@tamriel.snowman.net>
 <7b7035e0-3691-ca63-0957-25d17dc11514@2ndquadrant.com>
 <CAOuzzgrztzi+g5vfd-dtNxx+MByZcy9nMVzavYZTgvZGHx98Hg@mail.gmail.com>
 <5406.1554388830@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="HMvvK8TgObS3hPDC"
Content-Disposition: inline
In-Reply-To: <5406.1554388830@sss.pgh.pa.us>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk


--HMvvK8TgObS3hPDC
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Stephen Frost <sfrost@snowman.net> writes:
> > On Thu, Apr 4, 2019 at 05:20 Peter Eisentraut <
> > peter.eisentraut@2ndquadrant.com> wrote:
> >> Kerberos tests are now failing for me (macOS).
>=20
> > Interesting, they work locally for me on Ubuntu.  Unfortunately, I don=
=E2=80=99t
> > have macOS.  This only happens when encryption is being used, presumabl=
y?
> > GSS authentication is still working fine?
>=20
> The kerberos test suite passes for me on RHEL6 (kerberos 1.10.3),
> but I observe some compiler warnings that need to be dealt with:

Interesting, I don't see those with my build.  I'll have to figure out
why not.  Will fix them in any case.

> $ ./configure --with-gssapi ...
> $ time make -j8 -s
> be-secure-gssapi.c:597: warning: no previous prototype for 'be_gssapi_get=
_auth'
> be-secure-gssapi.c:609: warning: no previous prototype for 'be_gssapi_get=
_enc'
> be-secure-gssapi.c:621: warning: no previous prototype for 'be_gssapi_get=
_princ'
> pgstat.c: In function 'pgstat_bestart':
> pgstat.c:2986: warning: implicit declaration of function 'be_gssapi_get_a=
uth'
> pgstat.c:2987: warning: implicit declaration of function 'be_gssapi_get_e=
nc'
> pgstat.c:2990: warning: implicit declaration of function 'be_gssapi_get_p=
rinc'
> pgstat.c:2990: warning: passing argument 2 of 'strlcpy' makes pointer fro=
m integer without a cast
> ../../../src/include/port.h:429: note: expected 'const char *' but argume=
nt is of type 'int'
> All of PostgreSQL successfully made. Ready to install.
>=20
> I'm not very sure why the integer/pointer confusion in pgstat_bestart
> doesn't cause hard crashes when using gss auth --- or does
> this suite not actually test that?

Isn't it just saying that because of the implicit declaration..?
Once that's fixed, the integer/pointer warning will go away, but
it's actually a pointer in either case, hence why it isn't crashing.

The test suite does test GSS authentication and GSS encryption.

Thanks,

Stephen

--HMvvK8TgObS3hPDC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJcphkyAAoJEO1sijiDR2RV4NcP/RxIHcx4r76fOqQr21Pcotdj
ynrzrlqN8+VFFags83ijmrWsYseukJUEyIcD0FthGNdICV7PGjAaJmdE9ftDyAoy
NQpctZwnXqs+JeCQmZAnmPRPjkYLvXZ52narQn4xS0I2plQXp0fOibgpw7ajVJ0P
T+xfLi34urBJ/XeaN/tzX4Ow///EYycEdjGjGtVchZzPb283ndWo6oiyWLB1H0Zc
wSem5yPavSOqp4iRujRnQSdw/fMOYeuRo1axlV1tggIYBdDfEoWL/QcUNJvAaOVo
j1MCrUd7/dIGiDsviyvReHsePhOvgyg7M5M2s/W9rhzYXHpqQ4gHzy7YC30Qeos2
m4TH2102uVikMflwXyAv2B2wq4Jz1fYshG10l4q/rskAErXCa9N+5pn7Z4+KUx4a
Pxq+MTQh7Prcg4VcNtAGN0iLEIvLCF0mcCiAvMcTtZbLqh+gn2Ao3zBhf6AqJyNP
XPivNPdTV4B2d+qtVViI5qscdoYTUkZUgYN5S7FTIVgfSZGKb/UDcMpBfv1+2t8U
4figf6JGKHVeNPMajzaaTnUhLYj1GgNQItk9A6qoO79ef9b90fiMrc/crPRasmX/
I0UicLiELvuewy55Mcx4gYM8ks4PDKw7paRRBxTKCfWSM3On/N0H9vYQ+Auc2lsP
yRdQNBE0qt/ag6ZEnPxY
=qYTh
-----END PGP SIGNATURE-----

--HMvvK8TgObS3hPDC--