Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hC3rQ-0005bz-AH for pgsql-hackers@arkaria.postgresql.org; Thu, 04 Apr 2019 15:01:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hC3rO-0002vP-8e for pgsql-hackers@arkaria.postgresql.org; Thu, 04 Apr 2019 15:00:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hC3rO-0002vI-00 for pgsql-hackers@lists.postgresql.org; Thu, 04 Apr 2019 15:00:58 +0000 Received: from tamriel.snowman.net ([2001:470:e38f::11]) by magus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hC3rL-0004RF-Nu for pgsql-hackers@postgresql.org; Thu, 04 Apr 2019 15:00:57 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id D8F195F7A5; Thu, 4 Apr 2019 11:00:54 -0400 (EDT) Date: Thu, 4 Apr 2019 11:00:54 -0400 From: Stephen Frost To: Tom Lane Cc: Peter Eisentraut , Alvaro Herrera , David Steele , Joe Conway , Magnus Hagander , Michael Paquier , Nico Williams , PostgreSQL-development , Robbie Harwood Subject: Re: [PATCH v20] GSSAPI encryption support Message-ID: <20190404150054.GJ6197@tamriel.snowman.net> References: <1f799b02-d766-0328-45d6-73e5674d0bc2@2ndquadrant.com> <500b1be7-d0aa-96a2-9982-d748609faff5@joeconway.com> <20190403144332.GD6197@tamriel.snowman.net> <7b7035e0-3691-ca63-0957-25d17dc11514@2ndquadrant.com> <5406.1554388830@sss.pgh.pa.us> <20190404144818.GI6197@tamriel.snowman.net> <5945.1554389568@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZCZSln8LucFbpoWH" Content-Disposition: inline In-Reply-To: <5945.1554389568@sss.pgh.pa.us> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --ZCZSln8LucFbpoWH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Greetings, * Tom Lane (tgl@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (tgl@sss.pgh.pa.us) wrote: > >> I'm not very sure why the integer/pointer confusion in pgstat_bestart > >> doesn't cause hard crashes when using gss auth --- or does > >> this suite not actually test that? >=20 > > Isn't it just saying that because of the implicit declaration..? > > Once that's fixed, the integer/pointer warning will go away, but > > it's actually a pointer in either case, hence why it isn't crashing. >=20 > Well, if the caller thinks what is being passed back is an int, > it will do a 32-to-64-bit widening, which is almost certainly > going to result in a corrupted pointer. Oh, good point. Interesting that it still works then. I've got a fix for the missing prototypes, I hadn't noticed the issue previously due to always building with SSL enabled as well. I'm testing with a non-SSL build and will push the fix shortly. Thanks! Stephen --ZCZSln8LucFbpoWH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJcphwmAAoJEO1sijiDR2RV3xUQALlmNilydWA2nvlQUxvyQdYY 6FzkpyvqL0WuIyVS2wtgAmWwc7NcE9fBNtCSEX/XnJi1Uim5sugf+ESRE1lBJ2Nd FVtQmrzGX9haAf/7c9kcduJs+Bq6fFgS48RA9ZO6bqUEkjlouYIm2OPEuIjbvxUW PAdaLcvCIjwgCD+tndDvTN2Gjz/jhtlEwdfAXM8Gjm6Q0G3Giy71KirhErPw0fXW QYgcW84/g/0qUs/FGYkd6w29ObcMuV0kqt710IZn0NUIpm4XduU9w1mWiWZEiMPC Pwi8zDCXoEPQtSRoMpTcZEIzgVoGHoTeNs40xyByf5U++kx9O/u3zJTNkQ8iyAeo O8Qd0l6wJ7SHJIlli5ZfQMOyjRqsJ83ut3dq1/sJ4wy19jSVTEM4MR63Z+GiS5Ng NhBqpJCYfMfupFuNw12bocoq/YjC7V2piP8RqqidPXSbpR2AfIMjMURsyfLBRbwK uxYcUemehjstgRCHPj+cdPnDlrknP3cyOO99ZVPiLdpxfREmKRVBuMipLu1G9pgV H04E3H3Lll2beb5iUNHLtJT6O3+Vr0YI4+QYqIeRhG31rffyBwDIzcC+rwQjfDOb OtZ/W8KuGS/xRVctLHrfWCWEohuSzl1LiyrCO6R/5PIg7KlRYopBCSi3uEhkQ5R3 Z5GL5E2OeSEF6LY4L1RR =jlvy -----END PGP SIGNATURE----- --ZCZSln8LucFbpoWH--