Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hC5t9-0004Q7-IF for pgsql-hackers@arkaria.postgresql.org; Thu, 04 Apr 2019 17:10:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hC5t8-0004Lp-3x for pgsql-hackers@arkaria.postgresql.org; Thu, 04 Apr 2019 17:10:54 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hC5t7-0004Le-Oa for pgsql-hackers@lists.postgresql.org; Thu, 04 Apr 2019 17:10:53 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hC5t4-0006AL-MZ for pgsql-hackers@postgresql.org; Thu, 04 Apr 2019 17:10:52 +0000 Received: by mail-wr1-x441.google.com with SMTP id t17so4679569wrw.13 for ; Thu, 04 Apr 2019 10:10:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PBJe2no7ogNnkor/uuGJ40qH6uFZ5WLopB2r+s9Hp9M=; b=fDxy87w9XAJ9/t073LKjpYSo+P0Z6l83ufSuOBxUzK+pQpFhGGUszUg7Fb0FcNnzs1 Kibr6FHZA5RfHD9f2ZFaVhcHB8nYRwpsdxRrR9WkLG8cP5lZzR0BiYZ5P2Clh//G9Vdq lZe0QE1P0GeadOWo5W5/gXuyMLU+hFTI96QNjAhRRgq5x2Dc7p/Lq1vnvtKynKISY+Gi H+SdUriZvbsonpKOmQX9J4HWeIoy8kuYjReks890kQk2S/ph/Mk3f3KJCPuwvqHiBlAu lyPXh45vvSK15GXAn8iMF/qmWPxhZTktnll9FU8fkVpmzqTZA+Ms9FPd5D+lQSiuban7 uA8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PBJe2no7ogNnkor/uuGJ40qH6uFZ5WLopB2r+s9Hp9M=; b=RuPHR2VuWTmjqQzA7YDUTsSweO3vSE63WiuIz5m0EbzkC1fQilhDUjgasbxbwIGT3o hJAHKrAliX7gyZmxaX9xOtXghOVcDMSVJgIbwCy5O63n5t067k2Sp31NUwvpmWtd2MVY ZgdQjygPrXl6jYn923N4myKhppRuXyTs1rDq4VMpBZAql5JyX1Cx6jxPSbax7oig6PhI 4vDjEIGHSwfpXRNb4kN7guuqRwkdRzMw8EI8iy0+jRURSPWSUnC2yUkdRBuIN+oscKk3 MDCgYoGivz6gUDHREWj7lael/xErqk9boPOF2Jatj9VUwBUEtJrX7BrqIOm5Jciv7900 CLpQ== X-Gm-Message-State: APjAAAXCYhjkpuKcx8RnDUO968dBfwHk5ju+8RwQtBO/m4S9BmV9ZTgT rPsFsS62qmXPS5Dty6B2so9Vww== X-Google-Smtp-Source: APXvYqwtZV6c0suxjUFbc3wWXu6GU71gb1oZBUc1GvOoK/aam72o9J53aUvdFySRmgBvGVePFvw4nQ== X-Received: by 2002:adf:eaca:: with SMTP id o10mr5187319wrn.273.1554397847840; Thu, 04 Apr 2019 10:10:47 -0700 (PDT) Received: from localhost (static-84-42-175-93.net.upcbroadband.cz. [84.42.175.93]) by smtp.gmail.com with ESMTPSA id e16sm28367352wrs.0.2019.04.04.10.10.46 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 04 Apr 2019 10:10:46 -0700 (PDT) Date: Thu, 4 Apr 2019 19:10:44 +0200 From: Tomas Vondra To: Pavan Deolasee Cc: Masahiko Sawada , pgsql-hackers , Jeff Janes , Simon Riggs Subject: Re: COPY FREEZE and setting PD_ALL_VISIBLE/visibility map bits Message-ID: <20190404171044.tntdkim4nmnfyqfd@development> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-1432-ae87f8 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hi, I've been looking at this patch for a while, and it seems pretty much RFC, so barring objections I'll take care of that once I do a bit more testing and review. Unless someone else wants to take care of that. FWIW I wonder if we should add the code for partitioned tables to CopyFrom, considering that's unsupported and so can't be tested etc. It's not a huge amount of code, of course. regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services