Date: Thu, 4 Apr 2019 16:15:54 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: Pavan Deolasee <pavan.deolasee@gmail.com>,
	Masahiko Sawada <sawada.mshk@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	Jeff Janes <jeff.janes@gmail.com>,
	Simon Riggs <simon@2ndquadrant.com>,
	Tomas Vondra <tomas.vondra@2ndquadrant.com>
Subject: Re: COPY FREEZE and setting PD_ALL_VISIBLE/visibility map bits
Message-ID: <20190404191554.GA7161@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190404172417.gua2xmn754uoxzto@alap3.anarazel.de>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On 2019-Apr-04, Andres Freund wrote:

> I'm totally not OK with this from a layering
> POV. CheckAndSetAllVisibleBulkInsertState is entirely heap specific
> (without being named such), whereas all the heap specific bits are
> getting moved below tableam.

This is a fair complaint, but on the other hand the COPY changes for
table AM are still being developed, so there's no ground on which to
rebase this patch.  Do you have a timeline on getting the COPY one
committed?

I think it's fair to ask the RMT for an exceptional extension of a
couple of working days for this patch.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services