Date: Thu, 4 Apr 2019 20:35:37 -0700
From: Andres Freund <andres@anarazel.de>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Pavan Deolasee <pavan.deolasee@gmail.com>,
	Masahiko Sawada <sawada.mshk@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	Jeff Janes <jeff.janes@gmail.com>,
	Simon Riggs <simon@2ndquadrant.com>,
	Tomas Vondra <tomas.vondra@2ndquadrant.com>
Subject: Re: COPY FREEZE and setting PD_ALL_VISIBLE/visibility map bits
Message-ID: <20190405033537.vklegbflesm2c7m3@alap3.anarazel.de>
References: <20190404214520.7rfufsubxekodypr@alap3.anarazel.de>
 <20190405030604.GA3360@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190405030604.GA3360@alvherre.pgsql>
Precedence: bulk

Hi,

On 2019-04-05 00:06:04 -0300, Alvaro Herrera wrote:
> On 2019-Apr-04, Andres Freund wrote:
> > I still think this is the wrong architecture.
> 
> Hmm.

I think the right approach would be to do all of this in heap_insert and
heap_multi_insert. Whenever starting to work on a page, if INSERT_FROZEN
is specified, remember whether it is either currently empty, or is
already marked as all-visible. If previously empty, mark it as all
visible at the end. If already all visible, there's no need to change
that. If not yet all-visible, no need to do anything, since it can't
have been inserted with COPY FREEZE.  Do you see any problem doing it
that way?

Greetings,

Andres Freund