Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDsHn-000164-LM for pgsql-hackers@arkaria.postgresql.org; Tue, 09 Apr 2019 15:03:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hDsHm-0007cI-Ek for pgsql-hackers@arkaria.postgresql.org; Tue, 09 Apr 2019 15:03:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDsHm-0007cB-68 for pgsql-hackers@lists.postgresql.org; Tue, 09 Apr 2019 15:03:42 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDsHj-0005oR-Gl for pgsql-hackers@postgresql.org; Tue, 09 Apr 2019 15:03:41 +0000 Received: by mail-wr1-x433.google.com with SMTP id k17so21333994wrx.10 for ; Tue, 09 Apr 2019 08:03:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ypZQNSNK6ZuQ0p5Z7+4u8T1s7m0C20J7bXn14y9WBu0=; b=l2+b2QtU+eL6O/TJgJn//SGGxYYR9OF0qslzORCEXoHhQEmVFtWXOw3mRXJyvO/5Ur IpxvrieHxj1/EBytL0FfmTVu5CbTJp73pkhDJ8oqlFDSFf71dgLQTi8iT0A4NV9c5eTW HyafK20+WEosvmAMFP0uFsC+2sob3t73fg3fycXNz2EPxlpm9TNYPC/aUcgpFICLafmx Bl97QC6CVgBPKJ+QwE64nKD1ldZVJU+udNjanxc+03k/08B7IMxDFgaaPoDEm8zWa9wj cGcvdFuQ+3lOrbELpHNz4/lY+Ga5bt0s2jbB/R7d2gAue3ZjT2OA+nq9mtzsoTPaLsnm I1PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ypZQNSNK6ZuQ0p5Z7+4u8T1s7m0C20J7bXn14y9WBu0=; b=ausjId/Jjw+0toivCWJEJS4dnGT1a/qOTYWOGmvxOY/hlvCSpqEe0Pr29s5x1eI3yp a9cm+7wWbg4HrB0gSrYmniGxu3JziJ7idTC153b1VUbznG169IMHME+81EwE48CDWJ5U hgZPIOUnT9ZjBdVc+8u/QjLUc6O2t0u8wNUSl5AxfEIgucagwqGjL7ZhHP/YVJuqOd2l FHO2isE6YiaF05uwBQb5LME3pALkD29o4y6WqIzJ6fh7vCNYm0Z78oyh8mcXiEtwAvPp 2SBj6haYQ20e3aDBqAbssJCidW3E3DlaaoUnVXinKOzkuypv06PZkQV5gHmspekLHAaw iNxw== X-Gm-Message-State: APjAAAWNvHru/ftR5bpKnoSqYRILQzGfi6FQvJr7KmA3BLCGc7MLqgmd Zc9Id9Mqskgr9R4HkCEmhl/KXQ== X-Google-Smtp-Source: APXvYqx64PYAdFoOC8lvulz7s2FosWu/EHp/blJz8JmJb9Vm78lKPiEmTNVS9LnYdu2DVuihV3nKDg== X-Received: by 2002:a5d:4b01:: with SMTP id v1mr22555034wrq.48.1554822217774; Tue, 09 Apr 2019 08:03:37 -0700 (PDT) Received: from localhost (static-84-42-175-93.net.upcbroadband.cz. [84.42.175.93]) by smtp.gmail.com with ESMTPSA id t76sm22463736wmt.8.2019.04.09.08.03.36 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 09 Apr 2019 08:03:36 -0700 (PDT) Date: Tue, 9 Apr 2019 17:03:33 +0200 From: Tomas Vondra To: Kyotaro HORIGUCHI Cc: andres@anarazel.de, a.zakirov@postgrespro.ru, alvherre@2ndquadrant.com, ah@cybertec.at, magnus@hagander.net, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, pgsql-hackers@postgresql.org Subject: Re: shared-memory based stats collector Message-ID: <20190409150333.5iashyjxm5jmraml@development> References: <20190306224332.374sdf6hsjh27m7t@alap3.anarazel.de> <20190327.163625.38666406.horiguchi.kyotaro@lab.ntt.co.jp> <20190403195659.fcmk2i7ruxhtyqjl@alap3.anarazel.de> <20190404.092512.142064795.horiguchi.kyotaro@lab.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190404.092512.142064795.horiguchi.kyotaro@lab.ntt.co.jp> User-Agent: NeoMutt/20180716-1444-295967-dirty List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Thu, Apr 04, 2019 at 09:25:12AM +0900, Kyotaro HORIGUCHI wrote: >Hello. > >At Wed, 3 Apr 2019 12:56:59 -0700, Andres Freund wrote in <20190403195659.fcmk2i7ruxhtyqjl@alap3.anarazel.de> >> Unfortunately I don't think it's realistic to target this to v12. I >> think it was unlikely to make at the beginning of the CF, but since then >> development just wasn't quick enough to warrant aiming for it. It's a >> large and somewhat complex patch, and has some significant risks >> associated. Therefore I think we should mark this as targeting v13, and >> move to the next CF? > >I'd like to get this in 12 but actually the time is coming. If >everyone think that that is not realistic, I do that. > Unfortunately, now that we're past code freeze it's clear this is a PG12 matter now :-( I personally consider this to be very worthwhile & beneficial improvement, but I agree with Andres the patch did not quite get to committable state in the last CF. Conidering how sensitive part it touches, I suggest we try to get it committed early in the PG13 cycle. I'm willing to spend some time on doing test/benchmarks and reviewing the code, if needed. regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services