Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hFtJF-0007Il-3z for pgsql-hackers@arkaria.postgresql.org; Mon, 15 Apr 2019 04:33:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hFtIi-0001pv-6g for pgsql-hackers@arkaria.postgresql.org; Mon, 15 Apr 2019 04:33:00 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hFtIh-0006Ev-J3 for pgsql-hackers@lists.postgresql.org; Mon, 15 Apr 2019 04:32:59 +0000 Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hFsHC-0000UL-H9 for pgsql-hackers@lists.postgresql.org; Mon, 15 Apr 2019 03:27:38 +0000 Received: by mail-qt1-x843.google.com with SMTP id p20so17544531qtc.9 for ; Sun, 14 Apr 2019 20:27:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=7mbQZitUTpAehQ8Uhvj8G0pqVhejLlgu/OJgpsDCIuQ=; b=lO/g+a+wse0ByAxwohIBWaKbtP5Xeuqkk0HcrSk6TBFI3LNo5/J2R/sWdPpVrCe657 Te/HOdxDuq7Joq3sSV7tZO48CwOFe4lwLgizUkoEcTu+LAnhejUBdt20ON8Vg7Q/7PbS OgywtPRCdceXG4Pxh11V64bMJeAkF4LWKCxv3FS1g4c/qJLEDUq2lh1Sr88mVVXuem3d 1lctHiIDQ/h2jLuNAbflvyuGR0Gmac0zMtngPdYOYX9xotbbDW1RyKLxQnmKehBMCFMz stWSWwinptgq0Ksi92tDS1N65qUGJIT03WIlSMi1GrDdGl9/9Ks7OEmvNsqF4cpBVp12 0o/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=7mbQZitUTpAehQ8Uhvj8G0pqVhejLlgu/OJgpsDCIuQ=; b=rOC2bM13Bc1nQL5tyVo8Ku27l6gRrxQ6dwEqglYTiq3PwoXvpYV8mKzpEeaScU38mE yv6MRkJ7yeuwc3aj8kQt8RY/B2kgXkaGH9H2+bOONoBruXy6TPSr+j2cDZAJoePqhgab ThCVrrYDEH0cxNAccbmAk3loITbbkXDsc6/bHxnG+NrBOM9tW4MmIAUd9IigM2pKtSue E2xufzZOUPz1tririyPr231ft8UCGVHBNn2Qcdziap8kfGNZg80kb/3QEG6JZJfPEd/j LvcPiFoks4TH0Dd7Tmpqj5gKnAOv6NE0J+xLCZeug+ypvTo6k+snagAcM9i7NP8ktYNK xbPQ== X-Gm-Message-State: APjAAAVT9pA7+aAdggLrM5rFfumq4bp4K99LBdSJH3v9gMgwMcF+d/P+ zxD+oNqNBRNwPYeMDqS4Fq3mPhfnFzQ= X-Google-Smtp-Source: APXvYqxmdiMqLGqWlv28/k5RpjS/zLjyfYinYwrIUNAVGwh5BfapdIygA/v4e6Asx+FgG3iqBNs8UQ== X-Received: by 2002:a0c:924a:: with SMTP id 10mr58249346qvz.168.1555298807418; Sun, 14 Apr 2019 20:26:47 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([201.186.80.67]) by smtp.gmail.com with ESMTPSA id c84sm27857512qke.0.2019.04.14.20.26.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 14 Apr 2019 20:26:46 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id 34DEB120F4B; Sun, 14 Apr 2019 23:26:44 -0400 (-04) Date: Sun, 14 Apr 2019 23:26:44 -0400 From: Alvaro Herrera To: David Rowley Cc: Andres Freund , Tom Lane , PostgreSQL Hackers Subject: Re: pg_dump is broken for partition tablespaces Message-ID: <20190415032644.GA19697@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Apr-15, David Rowley wrote: > To be honest, if I'd done a better job of thinking through the > implications of this tablespace inheritance in ca4103025d, then I'd > probably have not bothered submitting a patch for it. We could easily > revert that, but we'd still be left with the same behaviour in > partitioned indexes, which is in PG11. Well, I suppose if we do decide to revert it for tables, we should do it for both tables and indexes. But as I said, I'm not yet convinced that this is the best way forward. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services