Date: Wed, 17 Apr 2019 19:42:19 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Andres Freund <andres@anarazel.de>
Cc: Daniel Verite <daniel@manitou-mail.org>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Cleanup/remove/update references to OID column
Message-ID: <20190418004219.GJ2854@telsasoft.com>
References: <20190408002847.GA904@telsasoft.com>
 <da5a314d-f92d-47ef-b005-8451f26de0f2@manitou-mail.org>
 <20190410165917.GD10080@telsasoft.com>
 <20190418002347.rlqmypv5prlpl2bg@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="TKYYegg/GYAC5JIZ"
Content-Disposition: inline
In-Reply-To: <20190418002347.rlqmypv5prlpl2bg@alap3.anarazel.de>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk


--TKYYegg/GYAC5JIZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Apr 17, 2019 at 05:23:47PM -0700, Andres Freund wrote:
> Thanks for the patch!

Thanks for fixing it up and commiting.

Would you consider the remaining two hunks, attached ?

Justin

--TKYYegg/GYAC5JIZ
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="v3-0001-Cleanup-remove-update-references-to-OID-column.patch"

From fcd6279d0681093e8741cc5a05879afc95751c40 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryzbyj@telsasoft.com>
Date: Tue, 2 Apr 2019 19:13:55 -0500
Subject: [PATCH v3] Cleanup/remove/update references to OID column...

..in wake of 578b229718e8f.

See also
93507e67c9ca54026019ebec3026de35d30370f9
1464755fc490a9911214817fe83077a3689250ab

Author: Justin Pryzby <justin@telsasoft.com>
Author: Daniel Verite <daniel@manitou-mail.org>
---
 doc/src/sgml/information_schema.sgml | 4 ++--
 doc/src/sgml/ref/insert.sgml         | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/doc/src/sgml/information_schema.sgml b/doc/src/sgml/information_schema.sgml
index 234a3bb..9c618b1 100644
--- a/doc/src/sgml/information_schema.sgml
+++ b/doc/src/sgml/information_schema.sgml
@@ -1312,8 +1312,8 @@
   <para>
    The view <literal>columns</literal> contains information about all
    table columns (or view columns) in the database.  System columns
-   (<literal>ctid</literal>, etc.) are not included.  Only those columns are
-   shown that the current user has access to (by way of being the
+   (<literal>ctid</literal>, etc.) are not included.  The only columns shown
+   are those to which the current user has access (by way of being the
    owner or having some privilege).
   </para>
 
diff --git a/doc/src/sgml/ref/insert.sgml b/doc/src/sgml/ref/insert.sgml
index 189ce2a..f995a76 100644
--- a/doc/src/sgml/ref/insert.sgml
+++ b/doc/src/sgml/ref/insert.sgml
@@ -554,7 +554,7 @@ INSERT <replaceable>oid</replaceable> <replaceable class="parameter">count</repl
    The <replaceable class="parameter">count</replaceable> is the number of
    rows inserted or updated.  <replaceable>oid</replaceable> is always 0 (it
    used to be the <acronym>OID</acronym> assigned to the inserted row if
-   <replaceable>rows</replaceable> was exactly one and the target table was
+   <replaceable>count</replaceable> was exactly one and the target table was
    declared <literal>WITH OIDS</literal> and 0 otherwise, but creating a table
    <literal>WITH OIDS</literal> is not supported anymore).
   </para>
-- 
2.7.4


--TKYYegg/GYAC5JIZ--