Date: Wed, 17 Apr 2019 23:14:13 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Andres Freund <andres@anarazel.de>
Cc: Daniel Verite <daniel@manitou-mail.org>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Cleanup/remove/update references to OID column
Message-ID: <20190418041413.GK2854@telsasoft.com>
References: <20190408002847.GA904@telsasoft.com>
 <da5a314d-f92d-47ef-b005-8451f26de0f2@manitou-mail.org>
 <20190410165917.GD10080@telsasoft.com>
 <20190418002347.rlqmypv5prlpl2bg@alap3.anarazel.de>
 <20190418004219.GJ2854@telsasoft.com>
 <20190418005115.r4mat75wvlski3ij@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190418005115.r4mat75wvlski3ij@alap3.anarazel.de>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk

On Wed, Apr 17, 2019 at 05:51:15PM -0700, Andres Freund wrote:
> Hi,
> 
> On 2019-04-17 19:42:19 -0500, Justin Pryzby wrote:
> > diff --git a/doc/src/sgml/information_schema.sgml b/doc/src/sgml/information_schema.sgml
> > index 234a3bb..9c618b1 100644
> > --- a/doc/src/sgml/information_schema.sgml
> > +++ b/doc/src/sgml/information_schema.sgml
> > @@ -1312,8 +1312,8 @@
> >    <para>
> >     The view <literal>columns</literal> contains information about all
> >     table columns (or view columns) in the database.  System columns
> > -   (<literal>ctid</literal>, etc.) are not included.  Only those columns are
> > -   shown that the current user has access to (by way of being the
> > +   (<literal>ctid</literal>, etc.) are not included.  The only columns shown
> > +   are those to which the current user has access (by way of being the
> >     owner or having some privilege).
> >    </para>
> 
> I don't see the point of this change? Nor what it has to do with oids?

It doesn't have to do with oids, but seems more correct and cleaner...to my
eyes.

> > -   <replaceable>rows</replaceable> was exactly one and the target table was
> > +   <replaceable>count</replaceable> was exactly one and the target table was
> The <replacable>rows</<replacable> reference is from your change
> :(.

Ouch, not sure how I did that..sorry for the noise (twice).

Thanks,
Justin