Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hJfTh-0005sf-2M for pgsql-hackers@arkaria.postgresql.org; Thu, 25 Apr 2019 14:35:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hJfTf-0004p1-Md for pgsql-hackers@arkaria.postgresql.org; Thu, 25 Apr 2019 14:35:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hJfTf-0004ei-7g for pgsql-hackers@lists.postgresql.org; Thu, 25 Apr 2019 14:35:55 +0000 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hJfTc-0001jR-HN for pgsql-hackers@lists.postgresql.org; Thu, 25 Apr 2019 14:35:54 +0000 Received: by mail-qt1-x841.google.com with SMTP id d13so317213qth.5 for ; Thu, 25 Apr 2019 07:35:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=4D3pHv6tfDS8t7QaqBlAQOW/VPVqajeQgQdFOteKNPw=; b=ruGie7rHw48M6IuQ/CmmRvwVlC3xD51KOtNq+UnowBNHSbbsjCjONscU832yRfAJgx /Oh1zZWJ/zoMm5zeNWl6CC8Lorpm7yl49BJo9Dw9iLXa8WgjvZIAbbu8gH7Ph4u2Tt83 4fZGir5Z4y8SNemlUHdj+B4Hx5sg6LtmbHmJTzxANepD3Rcfu0M0xvVyCoRw7e5HwIit SHFLEb/u4Px/aDs1fARf93LCc7bKq4qcwvzVQ909Cj6px4LJR6QpVYyHrX1/uylk63de A+77rMueq1ifokOrX4ofRbbKjVUhkocHoQ0+6hjWI0ABt5sXU1Frzycyo/otHEyjfKJM N2UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=4D3pHv6tfDS8t7QaqBlAQOW/VPVqajeQgQdFOteKNPw=; b=BLiONE8UxhXowlM0yJJW1pZkuXKpLSPt/Xc51ybIOG0AhNEVOHtzINjMP1TEVAS/TM JgS3eOeGrUR/Jp3u3WbGJf/sg4NUUzKbykIF4vIKA+Rxa4DLXqd615PNuvjPDRv06kuR RXGxpNMvYPRQcYFGGJF4Y5ExKXx7IbTvF+LbKfnIw14Zc+wVr1Q/V/TkCd/yMZ9YCrnm eVe39sJitaW1jcdCYg7+rPRJbTk9m3+l3O2eHz0XAtbuw1szHnzhc/ftBHO8rckKiKWn LM/8TU5VIPbKfXl5e+okDoE1olT7/k6TchlIn7QyWx6tqIHMV6kvEBEPxFEDSkDK1U9k 6c2Q== X-Gm-Message-State: APjAAAXbzFsT6XESj3bB9I+e2aJx62xKq3BV0eG6KObboL9E6aWLUkEP G4XbyQKcWUIl2N2Cdf2FQ5HunQ== X-Google-Smtp-Source: APXvYqxVokAMsoxnb/3QEgsmICqJ1rdx26s84xo355cL7VQRZSpY614/h1uxnnjKAu9WTIgEF9FHaQ== X-Received: by 2002:a0c:b885:: with SMTP id y5mr30683453qvf.25.1556202949610; Thu, 25 Apr 2019 07:35:49 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([190.121.29.3]) by smtp.gmail.com with ESMTPSA id t129sm10796609qkc.24.2019.04.25.07.35.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Apr 2019 07:35:49 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id C016A1202CD; Thu, 25 Apr 2019 10:35:46 -0400 (-04) Date: Thu, 25 Apr 2019 10:35:46 -0400 From: Alvaro Herrera To: David Rowley Cc: Robert Haas , Andres Freund , Tom Lane , PostgreSQL Hackers Subject: Re: pg_dump is broken for partition tablespaces Message-ID: <20190425143546.GA16922@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190424224037.GA824@alvherre.pgsql> User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk I have pushed this now, after putting back a few of the tests I had proposed earlier, as well as a couple of sentences in the docs to hopefully make it clearer how it works. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services