Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hL5x3-0006fw-Ky for pgsql-hackers@arkaria.postgresql.org; Mon, 29 Apr 2019 13:04:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hL5x2-0007zd-AO for pgsql-hackers@arkaria.postgresql.org; Mon, 29 Apr 2019 13:04:08 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hL5x1-0007zW-UC for pgsql-hackers@lists.postgresql.org; Mon, 29 Apr 2019 13:04:08 +0000 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hL5wz-0001P6-Au for pgsql-hackers@postgresql.org; Mon, 29 Apr 2019 13:04:06 +0000 Received: by mail-qk1-x741.google.com with SMTP id n81so5851571qke.2 for ; Mon, 29 Apr 2019 06:04:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=HtTvO2tlksFQRrgM1YC58IbXqzLzhC9PvPwEDnFbPas=; b=wM2NrBw7x/okabWsvw2eZBKoQp2sRCwtNj75P8WhoB/+qzIpYv2dog8NSzQjMXSLom bMRYO5k7/bmtb0ZXvytphWI3DlpHHZfQNNv74pWRpSP5VD4WmV+QvidfqBOZX1goTAro 5SmUMjnLxAkkCqKz25mA4izUQnTeimru4azuKbJNL5y6JB7/ELY1rmyvlcJuGd2E+26J /WrB7y9qDYvsEj0C4B22T71LAzS7uEd6bITw/ftQKcekBDiaMcx9Tb4dYs2Wmw/QNIAh VAL0lYlmTYjapiDJbrLDdWdxFFMBeNprQRMwgoyBx25NupdeNCQemKk8nrEK0/AYnHts 3HPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=HtTvO2tlksFQRrgM1YC58IbXqzLzhC9PvPwEDnFbPas=; b=Cwn5Ex4PznrWOKBv2QSfVOG0s0zdi0U9T7hJnooVzL0enr8qQno1EiIxmyTnKV+SIc KUriwrNkkq18Jzf47h7T/RMHFg/2pXnLv+J33FDFbW852gdk+d79AUKBGj9MoJE1qpHn hh5ES8ZepNpO6zT9BZrUr0ZhS8umQUbNpOrRQYtlK7zMWhsPGaUxmRoYGO34ks/yGWfJ JNS6P5M8kgIxT2f7tl/s59iEDzhj/Z5BY5vCKOCn8O5vLfkgGKX9/NPYLmQGz9wvHq7a oA/Ib/HiqkI7aMOuEIQno0ML5IZJnOQfbVv+HJsIx0kWvhgWfUtrs5BAtMugiSdMwrsg wblA== X-Gm-Message-State: APjAAAV4DUOn4k/n7OevtOedXDCvQ3/WEcVoFvIE6ituVTZCGlP9IuVo 6rq205g9GzoNPPh6p8tqZ4+Qj9bj0KQ= X-Google-Smtp-Source: APXvYqwagCQCcReQeK0t4Ol0nSqfTq8DjlFN/RaiId1aOMxklP2U5M+QHb5z6SelKaQ3JoNy1AAlCA== X-Received: by 2002:a37:b345:: with SMTP id c66mr43116205qkf.219.1556543043985; Mon, 29 Apr 2019 06:04:03 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([191.125.227.86]) by smtp.gmail.com with ESMTPSA id i123sm12720017qkf.9.2019.04.29.06.04.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Apr 2019 06:04:03 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id 754F912172A; Mon, 29 Apr 2019 09:03:21 -0400 (-04) Date: Mon, 29 Apr 2019 09:03:21 -0400 From: Alvaro Herrera To: Thomas Munro Cc: Shawn Debnath , Andres Freund , Robert Haas , Tom Lane , Dmitry Dolgov <9erthalion6@gmail.com>, PostgreSQL-development Subject: Re: Refactoring the checkpointer's fsync request queue Message-ID: <20190429130321.GA14886@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Apr-05, Thomas Munro wrote: > Ok, here is a patch that adds a one-typedef header and uses > SegmentIndex to replace all cases of BlockNumber and int holding a > segment number (where as an "index" or a "count"). Hmm, I now see (while doing the pg_checksum translation) that this patch didn't make it. Pity ... -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services