Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hLct7-0001lA-Go for pgsql-hackers@arkaria.postgresql.org; Wed, 01 May 2019 00:14:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hLct5-0002mj-EO for pgsql-hackers@arkaria.postgresql.org; Wed, 01 May 2019 00:14:15 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hLct4-0002mc-Pm for pgsql-hackers@lists.postgresql.org; Wed, 01 May 2019 00:14:15 +0000 Received: from mail-io1-xd33.google.com ([2607:f8b0:4864:20::d33]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hLcsx-0005rU-68 for pgsql-hackers@lists.postgresql.org; Wed, 01 May 2019 00:14:13 +0000 Received: by mail-io1-xd33.google.com with SMTP id u12so13843310iop.0 for ; Tue, 30 Apr 2019 17:14:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9Q7ySteL3DI5oKVzQZTEC5+DzojGGSgRxQypiNucYOE=; b=EgSkQz+DO9U2r5Eo+l7afwwOPSPEAM42qwh8B+dmnUuoGqOsIE9rCoT5XmY9R57/9n YBsROHmHxx1WMVowQ33Brdtv9NA9NfXD7ML7MWgjBfUm2VU59CeybfHFc554I9abkdJU hQWuJnFMQTwZFYkW2UJPJmExKdvHL0SvGBx+1t4qmETz22/ItK58gwfl2TCXEzPDLyZH 4WJC6I3BubABjDh90MDdDexmtHwLJhNA2/8rrroVRu5sJcEkNgfpuuLS4w7qkzdLH4Ch K+2j+QEw5jcdkfQPJA7y6j+NE9UDnYR1y4FH9fc5LG2yCm02Foa1ZAVm3aNQaYRcSGpB bXkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9Q7ySteL3DI5oKVzQZTEC5+DzojGGSgRxQypiNucYOE=; b=bdTFgEE/ORlI84Jz3y099VxPlSbrDZx2Kaa3U3SFFUcyJzfHj1GejlHzuSkAOBWRoG uUeSzSDOeGMkdyMx8CEOBukNkFQgR7DVbCUX9H6jgFZ9Ryhn4SYeXO3fRTn+3o2Ens32 JMTKXkbhM/N7lMqPZ50/3wX0Hb7T4pO2TL21OJg62mG82ftK8S5f4BrsFUSicLP+FNwI 9pNPdy2YYYKVkeBSueCIG/GzqCjAYm4pQgyyYFNkYgmzjYsreE2oKRJwFlLrw2ufD3Aj vccYlvswQsWA5HBau4zeZBtCCjaFel7xWymihS1NBxqtuo7eE2s/eidOIyizoLDZuZZP taEQ== X-Gm-Message-State: APjAAAW038y1L5tvdQGveHkamKh1c5A7Hi4aGnX/so5ETRLygc8Bozz6 7W4+62eyWcWMsDrHAJS9jmKlSPX8fxs= X-Google-Smtp-Source: APXvYqzq3ygdFslaGYdlgpp8goJOLN1NK3p2Imm+qhoEXCBgUJ4miyWG5J6hyLkNpwwWS0+ndn6gdA== X-Received: by 2002:a05:6602:2:: with SMTP id b2mr27886101ioa.245.1556669645961; Tue, 30 Apr 2019 17:14:05 -0700 (PDT) Received: from pryzbyj (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id a124sm2307246itc.18.2019.04.30.17.14.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Apr 2019 17:14:05 -0700 (PDT) Received: by pryzbyj (Postfix, from userid 1000) id 2EB39800AA7; Tue, 30 Apr 2019 19:14:04 -0500 (CDT) Date: Tue, 30 Apr 2019 19:14:04 -0500 From: Justin Pryzby To: Alexander Korotkov Cc: Bruce Momjian , PostgreSQL Hackers Subject: Re: doc: improve PG 12 to_timestamp()/to_date() wording Message-ID: <20190501001403.GN3925@telsasoft.com> References: <20190430183636.GA8175@telsasoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Tue, Apr 30, 2019 at 09:48:14PM +0300, Alexander Korotkov wrote: > I'd like to add couple of comments from my side. > > - returns an error because the second template string space is consumed > > - by the letter J in the input string. > > + returns an error because the second space in the template string consumes > > + the letter M from the input string. > > Why M? There is no letter "M" is input string. > The issue here is that we already consumed "J" from "JUN" and trying > to match "UN" to "MON". So, I think we should live > J here. The rest of this change looks good. Seems like I confused myself while resolving rebase conflict. Thanks for checking. Justin