Date: Tue, 30 Apr 2019 17:57:11 -0700
From: Noah Misch <noah@leadboat.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Daniel Gustafsson <daniel@yesql.se>,
	Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>,
	"9erthalion6@gmail.com" <9erthalion6@gmail.com>,
	"sfrost@snowman.net" <sfrost@snowman.net>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid
Message-ID: <20190501005711.GA503996@rfd.leadboat.com>
References: <20190331224233.GC891537@rfd.leadboat.com>
 <eUPnXaH0-lP5UPgJAeBbpVF-9I3A9TzxXyQOAsTBO4jmB1sFTzFs6vSwaRAnHTmoDo0wJ-EtuHeyM0vn1LO0xm6NPc_dR0dwOzg8dJrLqhU=@yesql.se>
 <20190404020543.GA1319573@rfd.leadboat.com>
 <20190404145319.GA1720877@rfd.leadboat.com>
 <20190408064141.GA2016666@rfd.leadboat.com>
 <CA+hUKG+4n6XE40s0HeMscVARwPvb_aZ78tDFE6A0uTrr7ZSwKQ@mail.gmail.com>
 <20190411062228.GB2620174@rfd.leadboat.com>
 <CA+hUKG+21EPwfgs4m+tqyRtbVqkOUvP8QQ8sWk9+h55Aub1H3A@mail.gmail.com>
 <20190421165903.GA3709194@rfd.leadboat.com>
 <CA+hUKGLEsjr_nbGtbHbaPnv3ryvhDM37ps=z9YCxdkKLxfi15Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CA+hUKGLEsjr_nbGtbHbaPnv3ryvhDM37ps=z9YCxdkKLxfi15Q@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk

On Tue, Apr 30, 2019 at 10:47:37PM +1200, Thomas Munro wrote:
> On Mon, Apr 22, 2019 at 4:59 AM Noah Misch <noah@leadboat.com> wrote:
> > On Thu, Apr 18, 2019 at 04:30:46PM +1200, Thomas Munro wrote:
> > > This causes make check-world to deliver a flurry of pop-ups from
> > > macOS's built-in Firewall asking if perl should be allowed to listen
> > > to all interfaces [...].
> >
> > That is unfortunate.  The "Allowing specific applications" section of
> > https://support.apple.com/en-us/HT201642 appears to offer a way to allow perl
> > permanently.  Separately, it wouldn't cost much for us to abandon that check
> > on !$use_tcp (non-Windows) configurations.
> 
> My system is set up not to allow that and I suppose I could go and
> argue with my IT department about that, but I'm interested in your
> second suggestion if the test is in fact not serving any useful
> purpose for non-Windows systems anyway.  Do you mean like this?
> 
> --- a/src/test/perl/PostgresNode.pm
> +++ b/src/test/perl/PostgresNode.pm
> @@ -1098,17 +1098,12 @@ sub get_new_node
>                 # native Perl (https://stackoverflow.com/a/14388707),
> so we also test
>                 # individual addresses.
>                 #
> -               # This seems like a good idea on Unixen as well, even
> though we don't
> -               # ask the postmaster to open a TCP port on Unix.  On Non-Linux,
> -               # non-Windows kernels, binding to 127.0.0.1/24
> addresses other than
> -               # 127.0.0.1 fails with EADDRNOTAVAIL.
> -               #

Deleting that comment paragraph isn't quite right, since we're still testing
127.0.0.1 everywhere.  The paragraph does have cause to change.

>                 # XXX A port available now may become unavailable by
> the time we start
>                 # the postmaster.
>                 if ($found == 1)
>                 {
> -                       foreach my $addr (qw(127.0.0.1 0.0.0.0),
> -                               $use_tcp ? qw(127.0.0.2 127.0.0.3) : ())
> +                       foreach my $addr (qw(127.0.0.1),
> +                               $use_tcp ? qw(0.0.0.0 127.0.0.2 127.0.0.3) : ())

This is what I meant, yes.

>                         {
>                                 can_bind($addr, $port) or $found = 0;
>                         }