Date: Tue, 7 May 2019 18:51:48 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, David Fetter <david@fetter.org>,
	PostgreSQL Development <pgsql-hackers@postgresql.org>
Subject: Re: New EXPLAIN option: ALL
Message-ID: <20190507225148.GP6197@tamriel.snowman.net>
References: <20190507073046.GI28936@fetter.org>
 <20190507154147.l32a3erg4mbycj7u@alap3.anarazel.de>
 <20190507163411.GM28936@fetter.org>
 <20190507164430.a7tig676hjzdnyyd@alap3.anarazel.de>
 <20190507212355.GQ28936@fetter.org>
 <20190507215449.3a4yb5kkoloq7yyw@alap3.anarazel.de>
 <4638.1557266803@sss.pgh.pa.us>
 <20190507221255.GO6197@tamriel.snowman.net>
 <5221.1557267912@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="MG8C415ZZIzpUuwD"
Content-Disposition: inline
In-Reply-To: <5221.1557267912@sss.pgh.pa.us>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk


--MG8C415ZZIzpUuwD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Stephen Frost <sfrost@snowman.net> writes:
> > I'm generally in favor of doing something like what Tom is suggesting
> > with VERBOSE, but I also feel like it should be the default for formats
> > like JSON.  If you're asking for the output in JSON, then we really
> > should include everything that a flag like VERBOSE would contain because
> > you're pretty clearly planning to copy/paste that output into something
> > else to read it anyway.
>=20
> Meh --- I don't especially care for non-orthogonal behaviors like that.
> If you wanted JSON but *not* all of the additional info, how would you
> specify that?  (The implementation I had in mind would make VERBOSE OFF
> more or less a no-op, so that wouldn't get you there.)

You'd do it the same way you proposed for verbose- eg: BUFFERS OFF, et
al, but, really, the point here is that what you're doing with the JSON
result is fundamentally different- you're going to paste it into some
other tool and it should be that tool's job to manage the visualization
of it and what's included or not in what you see.  Passing the
information about what should be seen in the json-based EXPLAIN viewer
by way of omitting things from the JSON output strikes me as downright
odd, and doesn't give that other tool the ability to show that data if
the users ends up wanting it without rerunning the query.

> >> I do feel that it's a good idea to keep ANALYZE separate. "Execute
> >> the query or not" is a mighty fundamental thing.  I've never liked
> >> that name for the option though --- maybe we could deprecate it
> >> in favor of EXECUTE?
>=20
> > Let's not fool ourselves by saying we'd 'deprecate' it because that
> > implies, at least to me, that there's some intention of later on
> > removing it
>=20
> True, the odds of ever actually removing it are small :-(.  I meant
> mostly changing all of our docs to use the other spelling, except
> for some footnote.  Maybe we could call ANALYZE a "legacy spelling"
> of EXECUTE.

Sure, that'd be fine too.

Thanks,

Stephen

--MG8C415ZZIzpUuwD
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJc0gwEAAoJEO1sijiDR2RVMXoP/iHhS+xcCXqmca66sxVc6X9p
8zqz91YnIp8Q8qsYTWkborJRDQURnhBI+Kl2KZBikTD7RLYOMD9v04D31b38iuQ7
shQ3jS8nYN4jwEEoJVwaIHLJuiD2V7BpAnud5RaEVieWJ4AgUaqrwkw46hZuNnMY
zRSDQlzzqBQLb/xlPAXaZ9pDtw8Eavlw8k/vl/EFHOiTLgjeI3o151nCByGR2FYP
iKFVC8c0NIloMLMWpSVwXv3gk+G9k4U9UoiQ7zACgyM7PTuZD0DsHK/BBVBIlLTY
5wmSvMGGl+4rSpNr3x3qql/Jkd5RycfO6OScrvRNrhbfLbrMjOx6AB1IpyBal5E0
rYsNOh1M2e5AbKPi86Mmup5xNTvnnwoKzwi2Qf4sBvavED/+iVNS9j9zsMrdscsx
317nzgjH7jHVcZGfP/i6H82nx0IUxe72A7Rut2ePxU3yP7XOXhJSK+6EhcnWSrm3
HjfdrzHYqdEx8DpQ0dSHeu1Kr2i+nCLhB8toihKvD7udEzyuzcdWXm7Pf0X4LdlP
lv0CxpJ2KclaNNZj8tR7QTdDyAYGwp5Zb4XoEBVX3v4neB/70Kb+57/sGjXKgbKJ
QxTgbgw0VeV2U+J5zWr1VeLBuIiDNS4xQp/EWzFfrvHVEp8BNSgs5xc3rASlCKkX
eZM7r6ywnnPJC4habt6R
=20Bk
-----END PGP SIGNATURE-----

--MG8C415ZZIzpUuwD--